Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenAI] Rename ModelDetails #43055

Closed
joseharriaga opened this issue Mar 28, 2024 · 0 comments
Closed

[OpenAI] Rename ModelDetails #43055

joseharriaga opened this issue Mar 28, 2024 · 0 comments
Assignees
@joseharriaga
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI
Milestone
2024-05

Comments

@joseharriaga
Copy link
Member

Currently leaning towards ModelInfo as per below.

https://apiview.dev/Assemblies/Review/abf39c5b6bd9459f81706dfc751197b5#022855ca1e21451894bf5490971b8830

joseharriaga 1 week ago
We should find a name for this one that works in all cases. Right now we have a funny assortment:

ModelDetails class
ModelDetailCollection class
GetModelInfo method
GetModels method

KrzysztofCwalina 1 week ago
In Storage (a library we often use as the precedent creating library) we call similar concepts with the Info suffix. Details suffix is used to return advanced properties. See https://apiview.dev/Assemblies/Review/08ee04476e40490cbafafb874632758e#Azure.Storage.Blobs.Models.BlobDownloadInfo
@joseharriaga joseharriaga added Client This issue points to a problem in the data-plane of the library. OpenAI labels Mar 28, 2024
@joseharriaga joseharriaga modified the milestones: 2024-04, 2024-05 Mar 28, 2024
@joseharriaga joseharriaga self-assigned this May 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joseharriaga joseharriaga

Labels
Client This issue points to a problem in the data-plane of the library. OpenAI
Projects
None yet
Milestone
2024-05
Development

No branches or pull requests
1 participant
@joseharriaga