Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up proxies to be used by tests to ensure client libraries can connect through...proxies... #3326

Closed
johanste opened this issue Feb 14, 2019 · 5 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. Test-Proxy Anything relating to test-proxy requests or issues.

Comments

@johanste
Copy link
Member

Azure/azure-sdk#175 tracks the requirement for client libraries to be able to connect through proxies. Just as it is a common requirement to support it, it is also a common requirement to verify said support. Having proxies that are set up to use auth (digest and basic) would presumably be needed for this.

@johanste johanste added the EngSys This issue is impacting the engineering system. label Feb 14, 2019
@johanste
Copy link
Member Author

FYI: @bterlson, @mssfang

@mikeharder
Copy link
Member

One idea I had:

  1. Run HTTP proxy in a docker container.
  2. Run tests in docker container with no outbound internet and only access to proxy container.
  3. Run tests, verify access through proxy works and direct access fails.

@kurtzeborn
Copy link
Member

@JimSuplizio, pretty sure this very old issue is covered by the work you're planning to do with recordings. Feel free to reword/fix/close this issue as you see fit and as it aligns with the recording epic you're working on.

@kurtzeborn kurtzeborn added the Central-EngSys This issue is owned by the Engineering System team. label Sep 28, 2020
@kurtzeborn kurtzeborn assigned scbedd and unassigned scbedd Mar 8, 2022
@scbedd
Copy link
Member

scbedd commented May 11, 2022

I will transfer this issue to sdk-tools and apply label to it. Test-proxy definitely supports this scenario if the policies on client side are set up properly.

The way it should work is

  • Request with original URI.
  • core package detects presence of HTTP_PROXY environment variable and updates target URI/headers.
  • Test-proxy policy applies last and updates the already updated target URI/headers to route to test proxy.
  • Test-proxy makes request to the proxy server, records result as normal.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 11, 2022
@scbedd scbedd transferred this issue from Azure/azure-sdk May 11, 2022
@scbedd scbedd added Test-Proxy Anything relating to test-proxy requests or issues. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 11, 2022
@scbedd scbedd assigned scbedd and unassigned JimSuplizio May 11, 2022
@scbedd
Copy link
Member

scbedd commented Feb 10, 2023

Closing, this is client side.

@scbedd scbedd closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. Test-Proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

No branches or pull requests

5 participants