Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerName should not be needed #38

Closed
yorek opened this issue May 29, 2021 · 3 comments
Closed

ServerName should not be needed #38

yorek opened this issue May 29, 2021 · 3 comments
Assignees
@kanika1894
Labels
enhancement New feature or request idle Inactive for 14 days

Comments

@yorek
Copy link
Collaborator

yorek commented May 29, 2021

Given that the connection string already contains the server name, the property ServerName in the YAML file should be removed. Just like the database name is retrieved from the connection string, also the server name can be retrieved from the connection string, therefore asking one param less to the end user
@yorek yorek added the need-to-triage Requires investigation label May 29, 2021
@kanika1894 kanika1894 added enhancement New feature or request and removed need-to-triage Requires investigation labels Jun 2, 2021
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jun 17, 2021
yorek added a commit to yorek/sql-action that referenced this issue Jun 18, 2021
@yorek
proposed improvement Azure#38
41685c4
@arvindshmicrosoft arvindshmicrosoft mentioned this issue Jun 19, 2021
Closed
@kanika1894 kanika1894 removed the idle Inactive for 14 days label Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jul 7, 2021

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jul 7, 2021
dzsquared added a commit that referenced this issue Jan 5, 2022
@dzsquared @yorek
ref PR #38 (#64)
61f1675 
* proposed improvement #38

* Update main.ts

fixed null/empty check

* moved check for required server address

* added more connection string tests

* improved code readability

* updated readme

* updated action.yml

* updated readme

* re-added support to server-name to retain backward compatibility

* removed unused code?

* improved readme

* corrected typos

* use server-name if specified

* added debug message and comment

* resolving test failure for connectionString.server

Co-authored-by: Davide Mauri <damauri@microsoft.com>
@dzsquared
Copy link
Collaborator

Now available in v1.1
https://github.com/Azure/sql-action/releases/tag/v1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanika1894 kanika1894

Labels
enhancement New feature or request idle Inactive for 14 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yorek @dzsquared @kanika1894