Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the holidays of Croatia, starting from the year 2020 #203

Merged
merged 5 commits into from
Feb 16, 2020

Conversation

krukru
Copy link
Contributor

@krukru krukru commented Feb 15, 2020

Starting from the year 2020, there are some changes to the national holidays of Croatia. Some holidays have changed names, some have been disbanded and a new holiday was added.
The holiday list which is valid from the year 2020 can be found at the "Narodne novine" https://narodne-novine.nn.hr/clanci/sluzbeni/2019_11_110_2212.html
(English: The People's Newspaper), the official gazette of the Republic of Croatia which publishes laws, regulations, appointments and official decisions and releases them in the public domain

Edit: The full list of changes

  • Statehood day is now celebrated at a new date. The old date is still remembered (called "Spomendan") as Independence Day (Dan neovisnosti), but is not an official holiday.
  • Homeland Thanksgiving Day has been given a different name to include Victory Day and Day of Croatian Defenders (full name: Dan pobjede i domovinske zahvalnosti i Dan hrvatskih branitelja/Victory and Homeland Thanksgiving Day and the Day of Croatian Defenders).
  • Independence Day is no longer an official holiday. (It is still remembered as a "Spomendan" and is called Croatian Parliament Day. This PR only removes the official holiday - does not add the "Spomendan").
  • A new official holiday is created called "Remembrance Day for Homeland War Victims and Remembrance Day for the Victims of Vukovar and Skabrnja"

@stelgenhof stelgenhof added this to the v2.3.0 milestone Feb 16, 2020
Copy link
Member

@stelgenhof stelgenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Everything looks good, only can you update the CHANGELOG.md file describing these changes (add it in the 'Unreleased' section). Cheers!

@krukru krukru force-pushed the croatia/2020-update branch 2 times, most recently from 3cfb553 to 4c207a7 Compare February 16, 2020 10:03
Marko Kruljac added 2 commits February 16, 2020 11:03
Includes changes to Croatia holidays starting from 2020
@krukru
Copy link
Contributor Author

krukru commented Feb 16, 2020

Hey @stelgenhof, I briefly updated the changelog and updated the PR description to include full list of changes.

@stelgenhof stelgenhof merged commit dfaec2c into azuyalabs:develop Feb 16, 2020
@krukru krukru deleted the croatia/2020-update branch October 5, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants