Netherlands Liberation day is only an official holiday every 5 years #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! However your code is failing some of the CI checks and also you haven't provided any unit tests. |
|
I added test cases for the holiday type and ran php-cs-fixer, not sure if it is okay to hardcode the years but there isn't really a way to currently generate a random year every X years as far as I could tell. |
|
@DRoet The checks have been rerun however still some errors with the unit tests. Have you checked locally the tests run successfully? |
|
@stelgenhof My bad I must've missed that locally, should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info here:
https://www.timeanddate.com/holidays/netherlands/liberation-day#:~:text=Is%20Liberation%20Day%20a,Netherlands%20every%205%20years.
Let me know if there is anything else to add.