-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add International Womens Day to DE-MV #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the appropriate unit tests for your change? Also, if you have any documentation or reference for this change, that would be great.
@ihmels Can you add the appropriate unit tests for your change? Also, if you have any documentation or reference for this change, that would be great. |
I have added a test. The source is https://www.ndr.de/nachrichten/mecklenburg-vorpommern/Frauentag-in-MV-Landtag-beschliesst-neuen-Feiertag,frauentag370.html. However, there is another source on Wikipedia that is already referenced via Where is the best place to put the source? |
@ihmels Good point regarding the source. You could override the |
@stelgenhof I've added the source and fixed the namespace in the test. Can you run the workflow again for these changes? |
@stelgenhof Can you approve the workflow again? |
@ihmels Can you check you once more? There are still some errors. |
@stelgenhof The error was:
This error was not related to my changes, but I fixed it. Can you run tests again? |
@ihmels I've made some fixes on the |
No description provided.