Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mexico Provider #329

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Mexico Provider #329

merged 12 commits into from
Dec 4, 2023

Conversation

gogl92
Copy link
Contributor

@gogl92 gogl92 commented Dec 4, 2023

Time ago I created a ticket to implement Mexico's provider but I didn't have the time to implement it #143

I saw this will conflict with #318 but looks like the PR it's stale at the moment, but I'm open to see if we can move that one instead or merge this and update the PR later, please let me know your thoughts @stelgenhof

@stelgenhof stelgenhof changed the title Mexico proivder Mexico Provider Dec 4, 2023
@stelgenhof stelgenhof self-requested a review December 4, 2023 12:17
@stelgenhof
Copy link
Member

@gogl92 Thank you very much for this PR! Yes, the Mexico provider is indeed also included in #318 but - as you said - I haven't had any feedback on that PR. So let's incorporate yours!

src/Yasumi/Provider/Mexico.php Outdated Show resolved Hide resolved
Copy link
Member

@stelgenhof stelgenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good!

@stelgenhof stelgenhof merged commit c3de06d into azuyalabs:develop Dec 4, 2023
20 checks passed
@gogl92
Copy link
Contributor Author

gogl92 commented Dec 4, 2023

All looking good!

Thank you! Having the pipelines running in my fork made it really easy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants