Issue 505 #10
Open
Issue 505 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed poorly styled code, accidental revert on httprequest. .
During login, new zulipServices object should be created to prevent
unnecessary caching of previously entered server url.
Also, any leading or trailing whitespaces should be removed from the url
before making the network request.
Fixes: #227.
Remove 'api/' from server url EditText as api.zulip.com does not exist anymore.
Fixes #233.
This should make it possible for development builds to use Google auth.
- Added a checkbox option in menu. - If auto theme is enabled then irrespective of preffered theme, it will be overridden by auto theme (depending on time). - User can switch theme even if auto theme is enabled, but it is for that instance only.
removed "theme" from end in the menu options (day/night/auto).
DeepCode ReportDeepCode analyzed this pull request. |
|
deepcode retry |
|
retry deepcode |
3 similar comments
|
retry deepcode |
|
retry deepcode |
|
retry deepcode |
|
deepcode retry |
1 similar comment
|
deepcode retry |
|
retry deepcode |
1 similar comment
|
retry deepcode |
DEEpCode Report (#0c3bbb)DeepCode analyzed this pull request. |
|
retry deepcode |
5 similar comments
|
retry deepcode |
|
retry deepcode |
|
retry deepcode |
|
retry deepcode |
|
retry deepcode |
|
DeepCode analyzed this pull request. Click to see more details. |
|
retry deepcode |
|
DeepCode analyzed this pull request. Click to see more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.