Master #2
Open
Master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show it when user narrowed to stream/topic/pm from drawer.
Fills the fields in the chatbox. This saves the time in
composing message.
Fixes #330.
Included a case when narrowed to self, then list size is 1, and set title as user name.
While narrowing, we should check if we have already narrowed to the required stream.
Account for message headers generated when messages are loaded above a
list of messages.
This is important because message headers are also counted as items in the
recyclerview and hence when retaining the position of visible message at
the top of list, we need to account for all the message headers generated
for the set of LoadPosition.ABOVE messages.
Fixes #353.
Fixes #290.
Don't toggle toolbar and floating button if messages doesn't occupy full screen.
New layout for in app notification which slides from top of the screen. part 8th of #309
When a picture is clicked and sent directly (without a crop or edit), it gets rotated by 90 as most phone cameras are landscape. To solve this, it'd be better to use the displayed image and save it in the current photo path before sending.
Currently, search is performed in home view. This is especially undesirable when the query gives a lot of matching results. It'd be helpful to be able to search in current view of the user.
added 29 commits
February 1, 2019 11:16
|
DeepCode analyzed this pull request. Click to see more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.