Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glyph of Deathcoil (lock) - not removing from craft queue once crafted #176

Closed
Esc1972 opened this issue Jun 6, 2024 · 3 comments
Closed

Comments

@Esc1972
Copy link

Esc1972 commented Jun 6, 2024

Hi,

Hopefully this ticket is more useful than my last one, no major issues and a great addon so thank you first of all.

One minor issue with Glyph of Death Coil (Warlock one), when i craft this and i am using the crafting queue and clicking process to craft the next glyph, after i've ran through and selected all that i want to craft, Glyph of Deathcoil (warlock) remains in the queue even when crafted. This means the addon creates multiple of these glyphs (1 each time i press process), unless i manually remove it from the queue.

The display is also unusual, displaying a number in brackets following the name, but perhaps this because it shares the name with the DK glyph. The DK glyph does not have this issue

image

Let me know if there is any more data or info i can provide
Thanks

@b-morgan
Copy link
Owner

b-morgan commented Jun 6, 2024

Damn Blizzard for using the same name!

Skillet-Classic uses the skillName as the recipeID because the actual recipeID was not available when Skillet-Classic was initially developed. It does attempt to create a unique recipeID when there are duplicate skillNames and that's what the number represents.

I have replicated the issue but I think this is going to take a while to fix.

@Esc1972
Copy link
Author

Esc1972 commented Jun 6, 2024

All good, it's very minor issue

b-morgan added a commit that referenced this issue Jun 6, 2024
@b-morgan
Copy link
Owner

b-morgan commented Jun 6, 2024

I was able to find a simple fix which is included in Skillet-Classic-1.92-alpha1.

@b-morgan b-morgan closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants