Update MainFrame.lua #177
Merged
Update MainFrame.lua #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed following error, occurs when clicking on a ring enchant: Usage: local icon = C_Item.GetItemIconByID(itemInfo) [string "=[C]"]: in function `GetItemIcon' [string "@Skillet-Classic/UI/MainFrame.lua"]:1892: in function `UpdateDetailsWindow' [string "@Skillet-Classic/UI/MainFrame.lua"]:975: in function `UpdateTradeSkillWindow' [string "@Skillet-Classic/UI/MainFrame.lua"]:2538: in function `ScrollToSkillIndex' [string "@Skillet-Classic/Skillet.lua"]:1603: in function `SetSelectedSkill' [string "@Skillet-Classic/UI/MainFrame.lua"]:2459: in function `SkillButton_OnClick' [string "*MainFrame.xml:359_OnClick"]:2: in function <[string "*MainFrame.xml:359_OnClick"]:1>
|
I have merged your pull request but I believe the right answer is to update the I hate scrapping Wowhead. |
|
Skillet-Classic-1.92-alpha3 has an updated Skillet.scrollData file. This should now have data for all the ring enchants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed following error, occurs when clicking on a ring enchant in the enchanting profession in cata classic: