Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder parameters for registerContainer #5

Closed
davidsteeb opened this issue Jun 12, 2020 · 2 comments
Closed

Reorder parameters for registerContainer #5

davidsteeb opened this issue Jun 12, 2020 · 2 comments

Comments

@davidsteeb
Copy link
Contributor

davidsteeb commented Jun 12, 2020

The order of the parameter for registering a new CType could be changed to move the icon to a position after the grid configuration so a minimum configuration can consist of CType, label, description, and grid.

public function registerContainer(
        string $cType,
        string $label,
        string $description,
        array $grid = [],
        string $backendTemplate = 'EXT:container/Resources/Private/Templates/Container.html',
        string $gridTemplate = 'EXT:container/Resources/Private/Templates/Grid.html',
        string $icon = 'EXT:container/Resources/Public/Icons/Extension.svg',
        bool $registerInNewContentElementWizard = true
    ): void
@achimfritz
Copy link
Contributor

grid Parameter should also be mandatory

@ervaude
Copy link
Contributor

ervaude commented Jul 13, 2020

Resolved by #26

@ervaude ervaude closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants