qodana : remove unused variables , parameters

b3b00 · Jan 9, 2024 · 7c0f4ae · 7c0f4ae
1 parent 1c51da8
commit 7c0f4ae
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 42 deletions.
diff --git a/src/samples/ParserExample/Program.cs b/src/samples/ParserExample/Program.cs
@@ -273,7 +273,7 @@ private static void TestThreadsafeGeneric()
                     }
                     catch (Exception e)
                     {
-                        ;
+                        Console.WriteLine($"error {e.Message} : {e.StackTrace}");
                     }
                 });
                 t.Start();
@@ -1168,7 +1168,6 @@ private static void Main(string[] args)
             Issue414();
             Issue414Expr();
             //Issue351();
-            //EscapeIt();
             // TestIssue332();
             //TestTemplateFor();
             // testErrors();
@@ -1349,29 +1348,6 @@ private static void TestIssue332()
 
         }
 
-        private static void EscapeIt()
-        {
-            char escape = '\\';
-            char delim = '"';
-            var value = "\\\"te\\\\\\\\st\\\"";
-            string newValue = "";
-            int i = 0;
-            while (i < value.Length)
-            {
-                char current = value[i];
-                if (current == escape)
-                {
-                    i++;
-                }
-
-                newValue += value[i];
-                i++;
-
-            }
-
-            ;
-        }
-
         private static void Issue351()
         {
             var parserInstance = new ExpressionParser();

diff --git a/src/sly/lexer/GenericLexer.cs b/src/sly/lexer/GenericLexer.cs
@@ -159,8 +159,7 @@ public LexerResult<IN> Tokenize(ReadOnlyMemory<char> source)
             LexerFsm = SetLexerMode(r, lexersStack);
 
             var ignored = r.IgnoredTokens.Select(x =>
-                new Token<IN>(default(IN), x.SpanValue, x.Position, x.IsComment,
-                    x.CommentType, x.Channel)).ToList();
+                new Token<IN>(default(IN), x.SpanValue, x.Position, x.CommentType, x.Channel)).ToList();
             tokens.AddRange(ignored);
 
 
@@ -208,7 +207,7 @@ public LexerResult<IN> Tokenize(ReadOnlyMemory<char> source)
                 LexerFsm = SetLexerMode(r, lexersStack);
 
                 ignored = r.IgnoredTokens.Select(x =>
-                    new Token<IN>(default(IN), x.SpanValue, x.Position, x.IsComment,
+                    new Token<IN>(default(IN), x.SpanValue, x.Position, 
                         x.CommentType, x.Channel, x.IsWhiteSpace, x.DecimalSeparator)).ToList();
                 tokens.AddRange(ignored);
 

diff --git a/src/sly/lexer/LexerBuilder.cs b/src/sly/lexer/LexerBuilder.cs
@@ -167,7 +167,7 @@ private static BuildResult<ILexer<IN>> Build<IN>(Dictionary<IN, (List<LexemeAttr
                     }
                     else
                     {
-                        result = BuildRegexLexer<IN>(attributes, result, lang);
+                        result = BuildRegexLexer<IN>(attributes, result);
                     }
                 }
                 else if (hasGenericLexemes)
@@ -233,7 +233,7 @@ private static bool IsGenericLexer<IN>(Dictionary<IN, (List<LexemeAttribute> lex
 
 
         private static BuildResult<ILexer<IN>> BuildRegexLexer<IN>(Dictionary<IN, (List<LexemeAttribute> lexemes,List<LexemeLabelAttribute> labels)> attributes,
-            BuildResult<ILexer<IN>> result, string lang = null) where IN : struct
+            BuildResult<ILexer<IN>> result) where IN : struct
         {
             var lexer = new Lexer<IN>();
             foreach (var pair in attributes)

diff --git a/src/sly/lexer/Token.cs b/src/sly/lexer/Token.cs
@@ -30,13 +30,13 @@ public class Token<T> where T:struct
         public bool Notignored;
 
 
-        public Token(T token, string value, LexerPosition position, bool isCommentStart = false,
-            CommentType commentType = CommentType.Single, int? channel = null, char decimalSeparator = '.' ) : this(token,new ReadOnlyMemory<char>(value.ToCharArray()),position,isCommentStart,commentType,channel, decimalSeparator:decimalSeparator)
+        public Token(T token, string value, LexerPosition position, 
+            CommentType commentType = CommentType.Single, int? channel = null, char decimalSeparator = '.' ) : this(token,new ReadOnlyMemory<char>(value.ToCharArray()),position,commentType,channel, decimalSeparator:decimalSeparator)
 
 {
         }
 
-        public Token(T token, ReadOnlyMemory<char> value, LexerPosition position, bool isCommentStart = false,
+        public Token(T token, ReadOnlyMemory<char> value, LexerPosition position, 
             CommentType commentType = CommentType.Single, int? channel = null, bool isWhiteSpace = false, char decimalSeparator = '.' )
         {
             IsWhiteSpace = isWhiteSpace;

diff --git a/src/sly/lexer/attributes/PopAttribute.cs b/src/sly/lexer/attributes/PopAttribute.cs
@@ -5,7 +5,7 @@ namespace sly.lexer
     [AttributeUsage(AttributeTargets.Field)]
     public class PopAttribute : Attribute
     {
-        public PopAttribute(string mode = null)
+        public PopAttribute()
         {
         }
     }

diff --git a/src/sly/lexer/fsm/FSMLexer.cs b/src/sly/lexer/fsm/FSMLexer.cs
@@ -452,7 +452,7 @@ private List<Token<N>> ConsumeIgnored(ReadOnlyMemory<char> source, LexerPosition
                     var currentCharacter = source.At<char>(position.Index);
                     if (WhiteSpaces.Contains(currentCharacter))
                     {
-                        var whiteToken = new Token<N>(default(N), source.Slice(position.Index, 1), position, false,
+                        var whiteToken = new Token<N>(default(N), source.Slice(position.Index, 1), position, 
                             CommentType.No,
                             Channels.WhiteSpaces, isWhiteSpace: true, decimalSeparator: DecimalSeparator);
                         ignoredTokens.Add(whiteToken);

diff --git a/src/sly/parser/generator/RuleParser.cs b/src/sly/parser/generator/RuleParser.cs
@@ -91,7 +91,7 @@ public IClause<IN> ChoicesOne(Token<EbnfTokenGeneric> head)
         [Production("choices : STRING")]
         public IClause<IN> ChoicesString(Token<EbnfTokenGeneric> head)
         {
-            var choice = BuildTerminalOrNonTerimal(head.Value, discard: false,explicitToken:true);
+            var choice = BuildTerminalOrNonTerimal(head.Value, discard: false);
             return new ChoiceClause<IN>(choice);
         }
 
@@ -105,7 +105,7 @@ public IClause<IN> ChoicesMany(Token<EbnfTokenGeneric> head, Token<EbnfTokenGene
         [Production("choices : STRING OR choices ")]
         public IClause<IN> ChoicesManyImplicit(Token<EbnfTokenGeneric> head, Token<EbnfTokenGeneric> discardOr, ChoiceClause<IN> tail)
         {
-            var headClause = BuildTerminalOrNonTerimal(head.Value,discard:false,explicitToken:true); 
+            var headClause = BuildTerminalOrNonTerimal(head.Value,discard:false); 
             return new ChoiceClause<IN>(headClause,tail.Choices);
         }
 
@@ -119,13 +119,13 @@ public IClause<IN> SimpleClause(Token<EbnfTokenGeneric> id)
 
         [Production("clause : STRING")]
         public IClause<IN> ExplicitTokenClause(Token<EbnfTokenGeneric> explicitToken) {
-            var clause = BuildTerminalOrNonTerimal(explicitToken.Value,discard:false, explicitToken :true);
+            var clause = BuildTerminalOrNonTerimal(explicitToken.Value,discard:false);
             return clause;
         }
 
         [Production("clause : STRING DISCARD")]
         public IClause<IN> ExplicitTokenClauseDiscarded(Token<EbnfTokenGeneric> explicitToken, Token<EbnfTokenGeneric> discard) {
-            var clause = BuildTerminalOrNonTerimal(explicitToken.Value,discard:true, explicitToken :true);
+            var clause = BuildTerminalOrNonTerimal(explicitToken.Value,discard:true);
             return clause;
         }
 
@@ -203,7 +203,7 @@ public GroupClause<IN> GroupClause(Token<EbnfTokenGeneric> id)
         [Production("groupclause : STRING ")]
         public GroupClause<IN> GroupClauseExplicit(Token<EbnfTokenGeneric> explicitToken)
         {
-            var clause = BuildTerminalOrNonTerimal(explicitToken.Value,discard:true, explicitToken :true);
+            var clause = BuildTerminalOrNonTerimal(explicitToken.Value,discard:true);
             return new GroupClause<IN>(clause);
         }
 
@@ -220,7 +220,7 @@ public GroupClause<IN> GroupClauseDiscarded(Token<EbnfTokenGeneric> id, Token<Eb
         [Production("groupclause : STRING DISCARD ")]
         public GroupClause<IN> GroupClauseExplicitDiscarded(Token<EbnfTokenGeneric> explicitToken, Token<EbnfTokenGeneric> discarded)
         {
-            var clause = BuildTerminalOrNonTerimal(explicitToken.Value, true, explicitToken:true);
+            var clause = BuildTerminalOrNonTerimal(explicitToken.Value, true);
             return new GroupClause<IN>(clause);
         }
 
@@ -235,7 +235,7 @@ public GroupClause<IN> GroupChoiceClause(ChoiceClause<IN> choices)
         #endregion
 
 
-        private IClause<IN> BuildTerminalOrNonTerimal(string name, bool discard = false, bool explicitToken = false)
+        private IClause<IN> BuildTerminalOrNonTerimal(string name, bool discard = false)
         {
 
             var token = default(IN);