Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark performance for generic lexer before System.Span use #126

Closed
b3b00 opened this issue Jun 13, 2019 · 2 comments
Closed

benchmark performance for generic lexer before System.Span use #126

b3b00 opened this issue Jun 13, 2019 · 2 comments
Assignees
@b3b00
Labels
performance Quality up-for-grabs urgent

Comments

@b3b00
Copy link
Owner

b3b00 commented Jun 13, 2019

after a quick test I found that GenericLexer from 2.2.5.1 seems faster ( *10) and use less memory (*5).
This must be further investigated.

It looks strange as usage of Span<> is there to use less memory !? Maybe the tweaking in FSMLexer introduces some performance regression.

if this reveal to be real. a rollback is necessary.
@b3b00
Copy link
Owner Author

b3b00 commented Jun 13, 2019

use of BenchmarkDotNet is a must.

b3b00 added a commit that referenced this issue Jun 13, 2019
@b3b00
#126 : benchmark project
dd4cd2c
b3b00 added a commit that referenced this issue Jun 13, 2019
@b3b00
Merge branch 'dev' into technical/#126
1394bf9 
* dev:
  code coverage
  cleaning
  remove string usage from fsmlexer
  string delimiters escaping in lexer callback
  string delimiters escaping in lexer callback : WIP, need rework
  NodeAction removal
  nuget.org api key renewal
  FSM node actions removal

# Conflicts:
#	sly/lexer/GenericLexer.cs
b3b00 added a commit that referenced this issue Jun 13, 2019
@b3b00
Merge pull request #127 from b3b00/technical/#126
ad154d4 
Technical/#126
@b3b00 b3b00 closed this as completed Jun 13, 2019
@b3b00
Copy link
Owner Author

b3b00 commented Jun 13, 2019 •
edited
Loading

After benchmarking and optimisation :

image

@b3b00 b3b00 self-assigned this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b3b00 b3b00

Labels
performance Quality up-for-grabs urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@b3b00