Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

| alternate choice operator #146

Closed
b3b00 opened this issue Jan 1, 2020 · 4 comments
Closed

| alternate choice operator #146

b3b00 opened this issue Jan 1, 2020 · 4 comments

Comments

@b3b00
Copy link
Owner

b3b00 commented Jan 1, 2020 •
edited
Loading

only for items of the same type : terminals or non-terminals. mixing both is forbiden.this only two keep visitor arguments simple.

  • for each choice generate a new rule ? beware cartesian products when many alternate in same rule. 

  • or maybe simpler add a new clause type, just like option or group
b3b00 added a commit that referenced this issue Jan 1, 2020
@b3b00
#146 initial :grammar and lexer
8d38e5c
b3b00 added a commit that referenced this issue Jan 1, 2020
@b3b00
#146 initial : choice clause
100806a
b3b00 added a commit that referenced this issue Jan 1, 2020
@b3b00
#146 : parser build UT
e4867d1
b3b00 added a commit that referenced this issue Jan 2, 2020
@b3b00
#146 : parse alternate choice clause
ce8332d
b3b00 added a commit that referenced this issue Jan 2, 2020
@b3b00
#146 : check alternate choice clause are not mixed
3236506
b3b00 added a commit that referenced this issue Jan 2, 2020
@b3b00
#146 : alternate non terminals
aa1130a
b3b00 added a commit that referenced this issue Jan 2, 2020
@b3b00
#146 : UT fixes
21c9bdc
b3b00 added a commit that referenced this issue Jan 2, 2020
@b3b00
Merge pull request #147 from b3b00/feature/#146-alternate-operator
9e5b551 
Feature/#146 alternate operator
@b3b00
Copy link
Owner Author

b3b00 commented Jan 2, 2020

https://github.com/b3b00/csly/wiki/EBNF-parser#alternate-choice

@b3b00 b3b00 closed this as completed Jan 2, 2020
b3b00 added a commit that referenced this issue Jan 2, 2020
@b3b00
#146 : repeatable/optionable choices
9997df2
@CP3088
Copy link
Contributor

CP3088 commented Jan 2, 2020

Love this addition! Would it be possible to add ignore [d] to a group or alternate choice containing only terminals?

Like this? [LEND | PLEND] [d]

@b3b00
Copy link
Owner Author

b3b00 commented Jan 3, 2020

it could be done even if it is not that simple. i will not look at it right now though

@b3b00
Copy link
Owner Author

b3b00 commented Jan 3, 2020

done, finally not that complicated. Only terminal alternative are discardable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@b3b00 @CP3088