System.ArgumentOutOfRangeException

[terac]

I got this exception during syntax checking of json files containing errors.

"Index was out of range. Must be non-negative and less than the size of the collection."

`

    [Fact]
    public void TestErrorMissingClosingBracket()
    {
        EbnfJsonGenericParser jsonParser = new EbnfJsonGenericParser();
        ParserBuilder<JsonTokenGeneric, JSon> builder = new ParserBuilder<JsonTokenGeneric, JSon>();
        Parser = builder.BuildParser(jsonParser, ParserType.EBNF_LL_RECURSIVE_DESCENT, "root").Result;

        ParseResult<JsonTokenGeneric, JSon> r = Parser.Parse("{");
        Assert.True(r.IsError);
    }

`
After a first glance at the code you don't check the position accessing tokens after end of list .

[b3b00]

Hi @terac ,

I am not sure but this seems to be your own testcase, isnt it ? If so feel free to debug and PR a bugfix.
I am currently quite busy at work with little time forCSLY.

Thanks for your testing, in parsing problems it is very difficult to test all posibilities. Glad you found this one.

Olivier

[b3b00]

@terac, I took time to check your test case. I don't reproduce the bug. All Unit tests are OK on branch dev. Which branch di you test on ? Have you added some kind of specific ?
Could you make a PR with your code so we could debug your trouble ?

Thanks

[terac]

I'll try to debug it in the evening.

[terac]

Should I commit to dev or make a separate branch for that issue?

[b3b00]

create a branch from dev than commit on it and send me and send me a pull-request. Never commit directly on dev branch.
for better tracking you should name your branch according to this issue : bugfix/78-argumentoutofrange or something like that