Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: fixed width for clock area #16

Closed
Walther opened this issue Feb 2, 2017 · 4 comments
Closed

Feature request: fixed width for clock area #16

Walther opened this issue Feb 2, 2017 · 4 comments

Comments

@Walther
Copy link

Walther commented Feb 2, 2017

By default, the clock area is text-aligned to the right edge of the bottom bar. Additionally, the font is variable-width. When a minute changes (or for more extreme effect, display seconds too), the clock twitches around as different numbers have different widths. As the clock is the rightmost thing on the bar, everything else right-floated on the bar moves around too.

Proposed solutions:

  • Allow setting a fixed width font
  • Add a setting for fixing the clock position
@b3by
Copy link
Owner

b3by commented Feb 2, 2017

This is actually an excellent point. I'll just fix the clock width, and will probably give the user the choice about the clock position (right, middle, left?) and font. Will look into it ASAP.
Thank you for this, never noticed as I just use hour/minute format!

@b3by
Copy link
Owner

b3by commented Feb 13, 2017

I'll probably go for the fixed width font solution. That could be triggered in the settings, even if I'm not completely happy with the final result.
I use the default Atom font, and seeing the monospaced thinghy down there kind of cools me down.

screenshot 2017-02-13 22 22 34

Anyway, the clock position will be fixed.

Another solution I'm trying to implement is the automatic calculation of the required space for a given format. When no width is set, I would fetch the size of the container div as clientWidth and increment it of a few pixels. Of course, I'm afraid this could break for some formats, especially for fancy locales where the required width heavily varies according to the time or date.

@b3by
Copy link
Owner

b3by commented Feb 14, 2017

Hum, apparently the fixed width thing works fine (I'm still refining it, but there should be no problem with that). Now, I'm not sure the fixed width option could be actually needed...

@b3by
Copy link
Owner

b3by commented Feb 19, 2017

Closing, it should be fixed with the new release!

@b3by b3by closed this as completed Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants