Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the last repo seems to have closed the other pull request we were chatting in. This is the renewed version. I don't know how to format my two proposals, I would have normally done them as branches but github only allows a single branch per pull request so I'm guessing we'll figure something out after a decision has been made regarding what solution to go for (like opening a new pull request with only a single commit)
My last message was:
Looking at rofi's source code, one can see that this file is created if the usual one cannot be created at
/run/user/1000
:https://github.com/davatorium/rofi/blob/next/source/rofi.c#L892
Thus, two solutions arise:
/run/user/1000
The commit titled "Init system agnostic solution" tries to do the first, as the problem relates to what init system one uses. This, obviously, brings maintainability concerns with it:
The commit titled "OpenRC solution" attemps to go the second route and provide the solution for OpenRC, seeing as it's the second most popular init system and the one I'm personally able to use. The reason I exclude systemd is that this highly unlikely to happen on it, maybe unless one messes up a config at a very deep level. This is because systemd ships with logind, which takes care of this and OpenRC does not, one has to either use elogind or deal with it themselves.
Markdown obviously open to change, I just did it the way I considered readable, seeing as the project does not seem to enforce guidelines on this.