Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofi's .rofi.pid #151

Merged
merged 3 commits into from
Nov 5, 2022
Merged

rofi's .rofi.pid #151

merged 3 commits into from
Nov 5, 2022

Conversation

surrealoatmeal
Copy link
Contributor

@surrealoatmeal surrealoatmeal commented Aug 7, 2022

Cleaning up the last repo seems to have closed the other pull request we were chatting in. This is the renewed version. I don't know how to format my two proposals, I would have normally done them as branches but github only allows a single branch per pull request so I'm guessing we'll figure something out after a decision has been made regarding what solution to go for (like opening a new pull request with only a single commit)

My last message was:
Looking at rofi's source code, one can see that this file is created if the usual one cannot be created at /run/user/1000:
https://github.com/davatorium/rofi/blob/next/source/rofi.c#L892
Thus, two solutions arise:

  1. just provide users with the workaround
  2. teach people how to fix their problems with /run/user/1000

The commit titled "Init system agnostic solution" tries to do the first, as the problem relates to what init system one uses. This, obviously, brings maintainability concerns with it:

  • If we support x init system's solution, will we have to also include y, z and t init system? Do we have a list of init systems we provide solutions for (the ones we support)?
  • Should a piece of software concerning xdg specification compliance even delve into that?

The commit titled "OpenRC solution" attemps to go the second route and provide the solution for OpenRC, seeing as it's the second most popular init system and the one I'm personally able to use. The reason I exclude systemd is that this highly unlikely to happen on it, maybe unless one messes up a config at a very deep level. This is because systemd ships with logind, which takes care of this and OpenRC does not, one has to either use elogind or deal with it themselves.

Markdown obviously open to change, I just did it the way I considered readable, seeing as the project does not seem to enforce guidelines on this.

@b3nj5m1n
Copy link
Owner

b3nj5m1n commented Nov 5, 2022

I prefer the init system agnostic approach, I went ahead and reverted your last commit.

Thanks for your contribution, and sorry for taking so long.

@b3nj5m1n b3nj5m1n merged commit 391b4b3 into b3nj5m1n:main Nov 5, 2022
b3nj5m1n added a commit that referenced this pull request Nov 6, 2022
Co-authored-by: b3nj4m1n <b3nj4m1n@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants