Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed correct location of exporting ZDOTDIR #189

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

realitymolder
Copy link
Contributor

"You can do this in /etc/zsh/zshenv " have been replaced by "You can do this in /etc/zshenv" as this is the correct location. Was fighting with this one for a while until I realized the correct location.

"You can do this in _/etc/zsh/zshenv_ " have been replaced by "You can do this in _/etc/zshenv_" as this is the correct location. Was fighting with this one for a while until I realized the correct location.
@b3nj5m1n
Copy link
Owner

b3nj5m1n commented Nov 9, 2022

Hi, first of all, thanks for bringing my attention to this.

I've actually had a ton of trouble getting this to work in the last 3 days while setting up a new system, and it's this exact issue.

Here's the thing, it seems like it can be either, accoring to the arch wiki, the way it's currently explained by xdg-ninja is correct, and that way works on my arch install. On NixOS, your solution is the only one that works.

I can't look into it right now, but it seems like this is distro specific for some reason? So unless we find more info we probably have to add a note that it could be either.

@realitymolder
Copy link
Contributor Author

Hi, first of all, thanks for bringing my attention to this.

I've actually had a ton of trouble getting this to work in the last 3 days while setting up a new system, and it's this exact issue.

Here's the thing, it seems like it can be either, accoring to the arch wiki, the way it's currently explained by xdg-ninja is correct, and that way works on my arch install. On NixOS, your solution is the only one that works.

I can't look into it right now, but it seems like this is distro specific for some reason? So unless we find more info we probably have to add a note that it could be either.

Very interesting. According to my testing, this was the issue on macOS + Fedora. I cannot guarantee on other Linux distros. But have you seen this only on Arch wiki? Maybe they are the one that made a mistake in the first place? :O

@b3nj5m1n
Copy link
Owner

It seems /etc/zshenv is the offial location, so I added a note that it might be different on some systems.

I also made the files a bit more consistent with each other.

Let me know if you're happy with these changes and I'll merge this!

@realitymolder
Copy link
Contributor Author

Yes! Looks good to me ! Merge away, thanks ! :)

@b3nj5m1n b3nj5m1n merged commit 68a61b1 into b3nj5m1n:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants