Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine user creation #1

Merged
merged 4 commits into from
Apr 27, 2016
Merged

Refine user creation #1

merged 4 commits into from
Apr 27, 2016

Conversation

gibbsoft
Copy link

  • Fix broken homeDirectory assignment.
  • Add firstname, surname, fullname support.
  • Add openldap_enable_user_creation boolean to enable or disable user creation.
  • Add sample openldap_server_users hash.
  • Update README.md.

…ame, surname, fullname support. Add openldap_enable_user_creation boolean to enable or disable user creation. Add sample openldap_server_users hash. Update README.md
william:
password: 26April1564
fullname: William Shakespeare
firstname: William
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may make sense to change this to givenname so it matches the ldap schema key

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did consider that, although personally I've never liked the attribute name 'givenname' as it seems meaningless to most people. Maybe it's just me, so I'll change it to givenname.

@b4ldr
Copy link
Owner

b4ldr commented Mar 31, 2016

Please see my comments.

Ultimately i don't use this functionality anymore as it doesn't support updating the user details and it should probably be rewritten to use an ansible module so would be happy to accept the merge if you have considered these things.

Thanks

@gibbsoft
Copy link
Author

Sorry for the delay, I've been busy with other projects. I've updated this PR with givenname instead of firstname. I'd like to see it merged, just for seeding new LDAP test instances.

@b4ldr b4ldr merged commit 3341b1e into b4ldr:master Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants