Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notebooks overlay #113

Merged
merged 1 commit into from
Nov 30, 2022
Merged

add notebooks overlay #113

merged 1 commit into from
Nov 30, 2022

Conversation

goern
Copy link
Member

@goern goern commented Nov 29, 2022

Signed-off-by: Christoph Görn goern@b4mad.net

@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2022
@goern
Copy link
Member Author

goern commented Nov 29, 2022

/deploy

@goern
Copy link
Member Author

goern commented Nov 29, 2022

@harshad16 I'm doing a /deploy for an overlay build, the PipelineRun give:

conditions:
  - type: Succeeded
    status: 'False'
    lastTransitionTime: '2022-11-29T09:28:58Z'
    reason: CouldntGetTask
    message: >-
      failed to create task run pod
      "aicoe-pipelinerun-1312c574-1d2e-453c-8d0f-a17306526f8e-pr-vtvpb": Pod
      "aicoe-pipelinerun-1312c574-1d2e-453c-8d0f-a17306526f8e-pr-bm2km" is
      invalid: [spec.volumes[9].secret.secretName: Required value,
      spec.containers[7].volumeMounts[1].name: Not found: "quay-creds"]. Maybe
      missing or invalid Task opf-ci-pipelines/pr-build-release

see https://tekton.operate-first.cloud/#/namespaces/opf-ci-pipelines/pipelineruns/aicoe-pipelinerun-1312c574-1d2e-453c-8d0f-a17306526f8e?pipelineTask=pr-build-release-run&view=status

the default for registry_secret seems to be not used, the param seems to be unset?

PS: can we incr the retention time for the PipelineRuns?

@goern
Copy link
Member Author

goern commented Nov 29, 2022

/kind bug
/assign @harshad16

@sesheta
Copy link
Member

sesheta commented Nov 29, 2022

@goern: GitHub didn't allow me to assign the following users: harshad16.

Note that only b4mad members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/kind bug
/assign @harshad16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added the kind/bug Categorizes issue or PR as related to a bug. label Nov 29, 2022
@goern
Copy link
Member Author

goern commented Nov 29, 2022

/deploy

@goern
Copy link
Member Author

goern commented Nov 29, 2022

is https://github.com/AICoE/aicoe-ci/blob/master/tasks/overlays-pipeline.yaml#L79 related? is there a params. missing?
Well, its more like the replace to that template is missing?

@harshad16
Copy link
Contributor

harshad16 commented Nov 29, 2022

As this repository is set for overlay build, the simple /deploy will not work.
Use /deploy <overlay-name> : for example: /deploy paddock

if you would like build all overlays, please comment for each overlays separately in one separate single comments each.

Signed-off-by: Christoph Görn <goern@b4mad.net>
@goern
Copy link
Member Author

goern commented Nov 30, 2022

/deploy notebooks

@sesheta
Copy link
Member

sesheta commented Nov 30, 2022

Additionally, no overlay for name notebooks found.

@goern
Copy link
Member Author

goern commented Nov 30, 2022

/deploy notebooks

@sesheta
Copy link
Member

sesheta commented Nov 30, 2022

Additionally, no overlay for name notebooks found.

@goern
Copy link
Member Author

goern commented Nov 30, 2022

Additionally, no overlay for name notebooks found.

@harshad16 is this failing because aicoe-ci is looking at .aicoe-ci.yaml of the base branch rather then the PR itself?

@harshad16
Copy link
Contributor

Additionally, no overlay for name notebooks found.

is this failing because aicoe-ci is looking at .aicoe-ci.yaml of the base branch rather then the PR itself?

yes @goern , we do the check for existing overlay on the base (default) branch

@goern goern changed the title WIP test-test add notebooks overlay Nov 30, 2022
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
@goern goern added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Nov 30, 2022
@goern
Copy link
Member Author

goern commented Nov 30, 2022

/approve

@sesheta
Copy link
Member

sesheta commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@sesheta sesheta merged commit fe43425 into b4mad:main Nov 30, 2022
@goern goern deleted the test-test branch November 30, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants