fix: use method instead of list

bUnit-dev · Nov 2, 2023 · b6f0be8 · b6f0be8
1 parent 6e1ebbf
commit b6f0be8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 16 deletions.
diff --git a/src/bunit.web.query/Labels/LabelOptions.cs b/src/bunit.web.query/Labels/LabelOptions.cs
@@ -0,0 +1,18 @@
+using AngleSharp.Dom;
+
+namespace Bunit;
+
+internal static class LabelOptions
+{
+	internal static bool IsHtmlElementThatCanHaveALabel(this IElement element) => element.NodeName switch
+	{
+		"INPUT" => true,
+		"SELECT" => true,
+		"TEXTAREA" => true,
+		"BUTTON" => true,
+		"METER" => true,
+		"OUTPUT" => true,
+		"PROGRESS" => true,
+		_ => false
+	};
+}
diff --git a/src/bunit.web.query/Labels/LabelQueryConstants.cs b/src/bunit.web.query/Labels/LabelQueryConstants.cs
diff --git a/src/bunit.web.query/Labels/Strategies/LabelTextUsingWrappedElementStrategy.cs b/src/bunit.web.query/Labels/Strategies/LabelTextUsingWrappedElementStrategy.cs
@@ -11,6 +11,6 @@ internal class LabelTextUsingWrappedElementStrategy : ILabelTextQueryStrategy
 
 		return matchingLabel?
 			.Children
-			.SingleOrDefault(n => LabelQueryConstants.HtmlElementsThatCanHaveALabel.Contains(n.NodeName, StringComparer.OrdinalIgnoreCase));
+			.SingleOrDefault(n => n.IsHtmlElementThatCanHaveALabel());
 	}
 }