35 uuuid assigner #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-candidate #36 +/- ##
=====================================================
Coverage ? 100.00%
=====================================================
Files ? 35
Lines ? 1376
Branches ? 0
=====================================================
Hits ? 1376
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
gcotelli
approved these changes
Apr 19, 2021
| @@ -16,14 +17,16 @@ IdentifierAssignerTest >> id: anId [ | |||
| { #category : #'test support' } | |||
| IdentifierAssignerTest >> nextId [ | |||
|
|
|||
| ^ '123' | |||
| nextId := nextId + 1. | |||
There was a problem hiding this comment.
Why are you doing this as an arithmetic operation instead of writing it like this
| currentId |
currentId := nextId.
nextId := nextId + 1.
^ currentId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Prevented the requirement to use UUID by just increasing the canvas id when the assigner was already assigned. This effectively prevents reuse of an id in different sessions, which anyway can only occur for identifier assigners that are kept from one request to another because of an instance variable in an application that has submitted and thus generated a key/session for its URL.