Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48 add comparison protocol #49

Merged
merged 17 commits into from
Feb 17, 2020
Merged

Conversation

nchillo
Copy link
Member

@nchillo nchillo commented Feb 12, 2020

Add comparison. StandardComparison, ExclusiveLogicalOr and extentions to SequentialCollection (withoutFirst).

Nicolas Chillo and others added 5 commits February 12, 2020 15:26
Change collection documentation to add withoutFirst and withoutFirst:
Add Comparison.md
@coveralls
Copy link

coveralls commented Feb 12, 2020

Coverage Status

Coverage decreased (-0.1%) to 99.905% when pulling 0f9ed81 on 48-Add-Comparison-protocol into 7201f51 on release-candidate.

Copy link
Member

@fortizpenaloza fortizpenaloza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find a better name than StandardComparison?

docs/Collections.md Outdated Show resolved Hide resolved
docs/Collections.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
nchillo and others added 5 commits February 13, 2020 10:46
Co-Authored-By: Francisco Ortiz Peñaloza <90245+fortizpenaloza@users.noreply.github.com>
Co-Authored-By: Francisco Ortiz Peñaloza <90245+fortizpenaloza@users.noreply.github.com>
Co-Authored-By: Francisco Ortiz Peñaloza <90245+fortizpenaloza@users.noreply.github.com>
Co-Authored-By: Francisco Ortiz Peñaloza <90245+fortizpenaloza@users.noreply.github.com>
Co-Authored-By: Francisco Ortiz Peñaloza <90245+fortizpenaloza@users.noreply.github.com>
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Show resolved Hide resolved
source/Buoy-Comparison/ExclusiveLogicalOr.class.st Outdated Show resolved Hide resolved
nchillo and others added 5 commits February 13, 2020 17:31
Co-Authored-By: Maximiliano Tabacman <mtabacman@users.noreply.github.com>
Co-Authored-By: Maximiliano Tabacman <mtabacman@users.noreply.github.com>
mtabacman
mtabacman previously approved these changes Feb 15, 2020
@mtabacman mtabacman merged commit 15d0a4b into release-candidate Feb 17, 2020
@mtabacman mtabacman deleted the 48-Add-Comparison-protocol branch February 17, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants