Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic.h : add member function derived() #54

Merged

Conversation

ManifoldFR
Copy link
Contributor

  • returns reference to derived type to avoid static_cast everywhere
  • fix typo ".generatr" -> ".generate" in MvVecGenBase (this fixes use of function templates of the form ret_type f(MvVecGenBase<Derived>&&))

… type

+ avoid static_cast everywhere
+ fix typo ".generatr" -> ".generate" in MvVecGenBase
@bab2min
Copy link
Owner

bab2min commented Aug 9, 2023

@ManifoldFR Sorry for late reply. I think it's good refactoring!
The failure case of test sets looks to be a hardware problem, not the code.
I'll merge it.

@bab2min bab2min merged commit 371ccb9 into bab2min:main Aug 9, 2023
123 of 124 checks passed
@ManifoldFR ManifoldFR deleted the topic/introduce-derived-member-func branch August 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants