Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going to existing directory is still showing the filter #207

Open
augustocdias opened this issue Apr 13, 2023 · 11 comments · May be fixed by #221
Open

Going to existing directory is still showing the filter #207

augustocdias opened this issue Apr 13, 2023 · 11 comments · May be fixed by #221
Labels
area/fish Catch all for changes in fish files triage/needs-info An issue that needs more investigation from maintainers or more info from the issue provider

Comments

@augustocdias
Copy link

When I cd to an exact match within the CWD it is still showing the filter to select an option.

This is happening in fish on mac os arm.

@babarot
Copy link
Owner

babarot commented Apr 13, 2023

More detail please

@babarot babarot added the triage/needs-info An issue that needs more investigation from maintainers or more info from the issue provider label Apr 14, 2023
@Nightlord851108
Copy link

I am in the same issue, too.
In arm, when you are cd in to an exist directory, it should be auto completed with tab.
For example: cd ~/Down and tap tab, and it will auto completed as cd ~/Download. But it did not.

@babarot babarot added the area/fish Catch all for changes in fish files label Apr 15, 2023
@ibeex
Copy link

ibeex commented Apr 16, 2023

same here Fish

(exists in cwd) should Go to dir without the filter command (same as builtin cd). But it shows **filter**

@augustocdias
Copy link
Author

So this gif shows what happens. When I cd into openmls it is the only one match and it still shows the filter

tty

@svengreb
Copy link

I guess this is a duplicate of #206.

@boyanxu
Copy link

boyanxu commented May 7, 2023

Same issue.
fish, arch_linux, x86_64

@Darkclainer
Copy link

Having same issue on master branch.

In my case the reason was that function _enhancd_filter_interactive received two entries from stdin, one of them was specified directory and the other some empty string (probably with whitespaces). I don't understand awk code, so my workaround was to change the function on line 32 from:

    switch "$count"
        case '1'

to

    switch "$count"
        case '2'

This should be fine, because it looks like this function will receive one empty entry in any case.

@augustocdias
Copy link
Author

@b4b4r07 is the solution from @Darkclainer the correct approach? I can open a PR if so.

@cyrusn
Copy link

cyrusn commented Sep 14, 2023

I encounter the same issue too.
even cd ~/Desktop/ still shows the filter.

@Walheimat
Copy link

I have the same issue, clean install of Ubuntu 23.10, using fish shell. Will use hack @Darkclainer suggested for now.

@Darkclainer
Copy link

@augustocdias, I saw you made a more correct (in my opinion) fix: augustocdias@a6b9835. Could you please create PR, so the maintainer, at least will identify the problem more clearly or hopefully will merge fix?

@augustocdias augustocdias linked a pull request Nov 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fish Catch all for changes in fish files triage/needs-info An issue that needs more investigation from maintainers or more info from the issue provider
Projects
None yet
9 participants