CLI for listing available versions of a library

[teodorlu]

Effort to solve #16.

Ready for review!

Improvement suggestions much welcome.

Design

Example usage:

$ neil dep versions :lib org.clojure/clojure :limit 4
:lib org.clojure/clojure :version 1.11.1-rc1
:lib org.clojure/clojure :version 1.11.0
:lib org.clojure/clojure :version 1.11.0-rc1
:lib org.clojure/clojure :version 1.11.0-beta1

Make sure listing versions works well by piping into CLI for adding a dependency. The neil add dep CLI takes an option map - which works great. We simply produce lines like :lib org.clojure/clojure :version 1.11.0.

neil add dep currently doesn't support input on stdin, only CLI arguments. To get around this, we can use xargs.

neil dep versions org.clojure/clojure | fzf | xargs neil add dep

Where fzf can be replaced by any command that selects a single line from stdin and prints that line on stdout.

Option without xargs (not implemented, only an idea)

If we wanted to avoid the need for xargs, we could support the - convention for reading input from stdin:

neil dep versions org.clojure/clojure | fzf | neil add dep -

If neil dep add can take stdin input, it also makes sense for it to be able to add multiple dependencies, one per line.

Remaining work / open questions.

• Doesn't work for git deps. What should we do here? Not sure.
  • Decision: print error and exit if coordinates are not found on Clojars or Maven. We can extend to support git deps later if we want to.
• Remove teodor-notes.org before merging
• Consider removing comment about Clojars API lacking a way to limit the number of recent versions
  • @borkdude what do you prefer here?
  • I removed the comment.
• Remove neil dep add CLI entrypoint
• Squash or cleanup git history
  • The current history is a mess. Rebasing might not make sense.
  • I'm leaning towards squashing into a single commit. @borkdude - preferences?
• Remove printlns and pprints.

[teodorlu]

The %%22s turn up as double quotes in the Maven search URL. They seem to correspond to searching for "org.clojure" rather than org.clojure as group. Both seem to produce identical results.

[teodorlu]

I'm just going to remove neil dep add entrypoint. That's a different topic.

[teodorlu]

The git? logic currently doesn't make any sense. You don't specify a version :sha to list versions.

(defn dep-versions [opts]
  (let [lib (or (:lib opts)
                (first (:cmds opts)))
        lib (symbol lib)
        git? (or (:sha opts)
                 (:latest-sha opts))
        versions (if git?
                   ::todo
                   (or (seq (clojars-versions lib opts))
                       (seq (mvn-versions lib opts))))]
    (doseq [v versions]
      (println :lib lib :version v))))

[teodorlu]

New solution: look for coordinates on Clojars / Maven. If the coordinates are not found, print error and return with an error code.

(defn dep-versions [opts]
  (let [lib (or (:lib opts)
                (first (:cmds opts)))
        lib (symbol lib)
        versions (or (seq (clojars-versions lib opts))
                     (seq (mvn-versions lib opts)))]
    (if-not versions
      (binding [*out* *err*]
        (println "Unable to find" lib "on Clojars or Maven.")
        (System/exit 1))
      (doseq [v versions]
        (println :lib lib :version v)))))

[teodorlu]

I just copied your existing help text structure.

[teodorlu]

Love how you're working with options. Great fit for Clojure, great fit for Unix CLIs.

[borkdude]

@teodorlu Is this PR ready?

About: Squash or cleanup git history
Not needed, I'll just squash/merge, after you remove anything you'd still like to remove.

[teodorlu]

@borkdude If squash & merge is fine - go for it!