Fetch latest stable slipset/deps-deploy, instead of hard-coding #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor change, which removes the hard-coding of the
`slipset/deps-deploy` version in the `build-alias` function.
I have tested the change locally using `bbin`, and see that `neil add
build` now uses `slipset/deps-deploy {:mvn/version "0.2.2}`
vedang
force-pushed
the
fix/fetch-latest-deps-deploy
branch
from
a125f51
to
ad8b34e
Compare
|
Some tests need some love I guess |
|
My bad! I didn't run the tests locally. I looked at the test results. They are unrelated to the current PR, but seem easy to fix. I'll fix them in a new commit and push the commit to this PR. |
The following tests were breaking before the changes in this commit: ``` FAIL in (latest-version-test) (dep_add_test.clj:9) expected: (= "1.11.1" (neil/latest-stable-mvn-version (quote org.clojure/clojure))) actual: (not (= "1.11.1" "1.11.2")) FAIL in (dep-upgrade-test-using-git-tags) (dep_upgrade_test.clj:71) deps can be added with --tag expected: (= "v2022.03.08" (:git/tag original)) actual: (not (= "v2022.03.08" "v2024.03.13")) FAIL in (dep-upgrade-test-using-git-tags) (dep_upgrade_test.clj:79) deps with :git/tag coords upgrade to latest tags expected: (= "v2022.03.08" (:git/tag original)) actual: (not (= "v2022.03.08" "v2024.03.13")) FAIL in (dep-upgrade-test-using-git-tags) (dep_upgrade_test.clj:84) deps with :git/tag coords upgrade to latest tags expected: (not= (:git/tag original) (:git/tag upgraded)) actual: (not (not= "v2024.03.13" "v2024.03.13")) ``` The reasons for this are: 1. The latest stable version of `org.clojure/clojure` is `1.11.2` 2. Running `git/find-github-tag 'clj-kondo/clj-kondo "v2022.03.08"` returns `nil`, which makes `neil` fetch the latest github tag instead. To fix this, we: 1. Bump the latest stable version for Clojure in tests to 1.11.2 2. Bump the tag version used for `clj-kondo/clj-kondo` to `v2024.03.13` (latest) in `dep add` tests. 3. Bump the tag version used for `clj-kondo/clj-kondo` to `v2024.03.05` (not latest, but exists) in `dep upgrade` tests.
|
I've fixed the broken tests and explained the issue in the commit message. Please re-review |
|
@vedang Yes, indeed those failing tests weren't related to your PR, but seem suspicious because when you add a |
|
Oh I see, you explained it indeed well in the commit message:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change, which removes the hard-coding of the
slipset/deps-deployversion in thebuild-aliasfunction.I have tested the change locally using
bbin, and see thatneil add buildnow usesslipset/deps-deploy {:mvn/version "0.2.2}Closes: #205
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an issue with a clear problem statement.
I have updated the CHANGELOG.md file with a description of the addressed issue.