'$' macro does not work in '->'

[carlzhc]

It seems $ macro only work in one command execution, not pipelined (tested in bb).

user=> (-> ($ echo hello) ($ sed p) deref :out slurp println)
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: No method in multimethod 'do-copy' for dispatch value: [java.lang.ProcessImpl$ProcessPipeInputStream java.lang.ProcessImpl$ProcessPipeInputStream] [at <repl>:13:1]

user=> (-> (process '[echo hello]) (process '[sed p]) deref :out slurp println)
hello
hello

[carlzhc]

Seems $ does not work in piping at all.

[borkdude]

@carlzhc Should it? We can try to fix it. But since you closed this, you might not be interested in it anymore?

[borkdude]

I think it was supposed to work, but something may have been broken recently when we added support for passing options in the first position instead of via metadata..

process/src/babashka/process.cljc

Line 354 in eb03513

(if (:proc fcmd#)

[borkdude]

You know what, I undocumented $ and made it deprecated. I think it's more trouble/magic than it's worth.

[carlzhc]

Actually, I found the '$' does not support piping at all.
The first argument is supposed to be an option map to the command, not a previous command record as in 'process'.

[borkdude]

I've looked into this more and the fix wasn't so difficult. I decided to undeprecate $.