This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Patch SpreadProperty to escope's PatternVisitor #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once new escope is released, we can patch SpreadProperty to PatternVisitor. This will solve estools/escope#88 and eslint/eslint#4481.
|
Well, I have been testing this code (using the branch directly, because this is a serious issue), and so far seems to be ok... Any perspectives of when will it be merged? |
|
+1: This seems to fix #210 - using the code locally right now to fix the |
hzoo
added a commit
that referenced
this pull request
Nov 23, 2015
Patch SpreadProperty to escope's PatternVisitor
|
Ok merging and releasing. Ok interesting that the test fails now in travis |
|
@Constellation getting errors after merging now - don't have time at the moment to look into it |
|
The pull request was using eslint 1.9.0, and the merged test used eslint 1.10.1. Something changed between 1.9.0 and 1.10.1 was evidently not backward-compatible. |
evocateur
pushed a commit
to evocateur/babel-eslint
that referenced
this pull request
Nov 23, 2015
Despite the improvements from babel#209 with the pattern visitor, it doesn't actually iterate over the Property node siblings of the SpreadProperty. Thus, the "ignore properties left of spread" fix in babel#95 regressed. Restoring the "old" path of looping over all properties of an ObjectPattern that contains a SpreadProperty avoids the regression. It seems inelegant, but I don't have enough insight into the referencer to propose an alternative.
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
…visitor Patch SpreadProperty to escope's PatternVisitor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once new escope is released, we can patch SpreadProperty to PatternVisitor.
This will solve estools/escope#88 and eslint/eslint#4481.
See escope side PR: estools/escope#89