Explicitly resolve lowest browser version #121
Conversation
|
Nit, but can we dasherize the fixture names ( |
brokenmass
force-pushed
the
explicit-versions-ordering
branch
from
6c6f202
to
33164d3
Compare
|
@existentialism : oops my bad, fixed. |
| import "core-js/modules/es7.object.get-own-property-descriptors"; | ||
| import "core-js/modules/web.timers"; | ||
| import "core-js/modules/web.immediate"; | ||
| import "core-js/modules/web.dom.iterable"; |
There was a problem hiding this comment.
These 3 builtIns is included by default in any cases because of lack of info about it's support #111 . Let's use something simpler, like arrow functions:
const a = () => 1;
stop relying on browserlist returning a list sorted by browser version fix babel#119
brokenmass
force-pushed
the
explicit-versions-ordering
branch
from
33164d3
to
fee80a2
Compare
|
modified as requested |
|
@brokenmass Looks good! Also the tests will fail if we add some shims in the future. But we haven't any features < ios 9, so using builtIns seems to be the only way if we want to test ios 6. |
|
We should have a test with multiple browserlist entries like the original issue right? I don't see how the tests cover the changes in code atm since it seems to just test iOS (which is good too) |
|
As the problem was caused by the getLowestVersions algorithm the query |
stop relying on browserlist returning a list sorted by browser version
fix #119