Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Update yarnfile #145

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Update yarnfile #145

merged 1 commit into from
Jan 17, 2017

Conversation

baer
Copy link
Contributor

@baer baer commented Jan 17, 2017

The following changes have been made since the last update to the yarnfile.

-    "compat-table": "kangax/compat-table#e732718eab42c6c83a364450f456474638d31f94",
-    "eslint": "^3.3.1",
-    "eslint-config-babel": "^3.0.0",
-    "eslint-plugin-babel": "^4.0.0",
+    "compat-table": "kangax/compat-table#b0cec63ea21f3a7788a8eececcb918de903b7fc5",
+    "eslint": "^3.13.1",
+    "eslint-config-babel": "^5.0.0",

If yarn is used as the primary package manager it might be worth doing a yarn install in CI to make sure it comes up clean. I'm happy to try to set that up. Anyway, this will get the file up to date so I can get this guy into shape without committing extraneous stuff.

@baer baer merged commit d726a5b into master Jan 17, 2017
@baer baer deleted the feature/update-yarnfile branch January 17, 2017 17:29
@hzoo
Copy link
Member

hzoo commented Jan 19, 2017

Should we make sure to do npm run build-data after each change? - this is to know if there's a bug etc either with our code or via compat-table

@hzoo
Copy link
Member

hzoo commented Jan 19, 2017

Ok yeah getting that issue again.. why.. (removing chrome, ios, etc)

@baer
Copy link
Contributor Author

baer commented Jan 19, 2017

I actually had a lot of trouble with Yarn :/... What is the issue you're getting?

@hzoo
Copy link
Member

hzoo commented Jan 19, 2017

The issue is that running npm run build-data is causing the data/ to change when it shouldn't, not sure if it's yarn or compat-table update

@baer
Copy link
Contributor Author

baer commented Jan 19, 2017

I just pulled master and got a clean run of npm run build-data. That dependency is pinned to a SHA so I'm not sure why our runs would be different.

@hzoo
Copy link
Member

hzoo commented Jan 19, 2017

Ok cool, maybe yarn version/cache/etc 😓 ?

@existentialism
Copy link
Member

Same, with both yarn build-data and npm run build-data

@baer
Copy link
Contributor Author

baer commented Jan 19, 2017

I just ran both

  • rm -rf node_modules && yarn && npm run build-data
  • rm -rf node_modules && npm install && npm run build-data

And I got a clean master both times. That narrows it down to a cache issue (on one of our machines.)

@baer
Copy link
Contributor Author

baer commented Jan 19, 2017

I get this error every time I do a fresh yarn on this project:

[2/4] 🚚  Fetching packages...
error An unexpected error occurred: "ENOTEMPTY: directory not empty, rmdir '/Users/ebaer/Library/Caches/Yarn/npm-core-js-2.4.1-4de911e667b0eae9124e34254b53aea6fc618d3e/library/fn'".
info If you think this is a bug, please open a bug report with the information provided in "/Users/ebaer/dev/opensource/babel-preset-env/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

It is related to the pinned version of the compat table. When I remove the package, run yarn, put it back in and rerun the cmd it runs just fine. My guess is that this is a corner case that yarn just doesn't handle well. I was able to run:

npm cache clean && rm -rf node_modules && npm install && npm run build-data

And still get a clean master which again points to a problem with yarn and very likely with the pinned compat-table.

@hzoo
Copy link
Member

hzoo commented Jan 19, 2017

Oh I just got that error ^

and it works with npm ^. same page then lol

@baer
Copy link
Contributor Author

baer commented Jan 19, 2017

Can it be pinned to a regular version? Why use a SHA here?

@hzoo
Copy link
Member

hzoo commented Jan 19, 2017

There are no regular versions since it's not on npm (that's a wip)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants