This repository has been archived by the owner on May 11, 2018. It is now read-only.
Add test for invalid electron version #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorsky
reviewed
Feb 27, 2017
src/index.js
Outdated
| invariant( | ||
| !!electronChromeVersion, | ||
| `Electron version ${targetOps.electron} is either too old or too new` | ||
| ); |
There was a problem hiding this comment.
Maybe let's place this stuff to normalize-options module like other options' validations?
existentialism
force-pushed
the
add-electron-fail
branch
from
ac36828
to
12c0357
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the middle of refactoring/clean up some things to fix #154 and figured I'd push up some small housekeeping bits.
Ref: #125 (comment)