This repository has been archived by the owner on May 11, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
For now, we have excess
.filter(Boolean)
while processing preset's result:Firstly, there are extra checks for modules:
Then we iterate all modules array to get only single matched module:
By the end, we are processing new iteration by filtering preset's result:
despite:
modules
arrayplugins
can't contain anything except array(it's result ofallTransformations.map
which returns array only and throws error if no plugin was found).So, we are iterating the whole array to check only last value.
How this PR optimizes aforesaid?
MODULE_TRANSFORMATIONS
to check and get module's plugin.