This repository has been archived by the owner on May 11, 2018. It is now read-only.
Refactor build data for clarity/consistency #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baer
commented
Dec 12, 2016
| const fs = require("fs"); | ||
| const path = require("path"); | ||
|
|
||
| const flatten = require("lodash/flatten"); | ||
| const flattenDeep = require("lodash/flattenDeep"); | ||
| const mapValues = require("lodash/mapValues"); |
There was a problem hiding this comment.
This method is my new favorite! I learned about it ~1mo ago. I just ❤️ lodash.
There was a problem hiding this comment.
There's also Object.values and the new Object.entries if we wanted to use transform-runtime but don't have to. Or even polyfill since this is the build script.
baer
commented
Dec 12, 2016
| // normalize some keys | ||
| .map((test) => envMap[test] || test) | ||
| .filter((test) => !isNaN(parseInt(test.replace(env, "")))) | ||
| .shift(); |
There was a problem hiding this comment.
This block + the one below it are whitespace only changes... I'm not sure why GitHub is showing it like this.
|
Cool 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 5 updates to the
build-data.jsscript.package.jsonwas changed to not rely on Babel. Node6 obviates the need for this 🎊 !environmentsare passed togenerateDatamaking it a pure function of it's argumentsgenerateDatawas changed to usemapValuesin place ofObject.keys(obj).forEach(...)