Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

Bower support: babel.js and babel.min.js are available after installation #13

Closed
wants to merge 1 commit into from

Conversation

amoilanen
Copy link

There is already a Bower package published by somebody 'babel-standalone-bower', but unfortunately it does not include the files babel.js and babel.min.js after running bower install babel-standalone-bower

After this PR the built Babel files will be available in the directory ./bower_components/babel-standalone-bower

Having built version available in the root is a common pattern when publishing to Bower, as can be seen, for example, in the Underscore.js project https://github.com/jashkenas/underscore

@Daniel15
Copy link
Member

Sorry, but I'm not going to do this. Including build artifacts in source control is an anti-pattern and a pretty big code smell. The fact that other projects do it does not necessarily mean it's the right thing to do, and I'm not going to do it just for the sake of supporting Bower.

Release/artifact management and source control management are two different things. Release management is handled by npm and by the builds available on the releases page: https://github.com/Daniel15/babel-standalone/releases

Two alternative solutions I can think of:

  • Have a script that pulls the latest build of babel-standalone from npm and publishes it to a separate repo for Bower to consume
  • Automatically push it to a Bower repo as part of every build (eg. through TravisCI)

@Daniel15 Daniel15 closed this Jan 25, 2016
@amoilanen
Copy link
Author

Any alternative solution is also fine, provided that it will result in a working Bower package.

Now the installation of babel-standalone is a bit problematic because of the lack of Bower support.

One way, like it is also usually done, is to create a separate repository to where the built artifacts will be automatically pushed. Then the Bower package will point to this repository created for Bower.

@Daniel15
Copy link
Member

I added Bower support, you should be able to bower install babel-standalone. Bower pulls directly from a Git repo, so I had to create a separate repo to contain the build artifacts (https://github.com/Daniel15/babel-standalone-bower). I didn't want them clogging up the main repo - A Git repo is not the right place for build artifacts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants