Update packages appropriately for Webpack v1 compatibility #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing test failure that's happening because my code assumes dev deps always exist. |
adityavohra7
force-pushed
the
babel_upgrade_issue_17
branch
from
cf4da9b
to
a3b6144
Compare
|
Great, we just need a test fixture for this as well |
adityavohra7
force-pushed
the
babel_upgrade_issue_17
branch
from
a3b6144
to
0919fbe
Compare
adityavohra7
force-pushed
the
babel_upgrade_issue_17
branch
from
0919fbe
to
885f96e
Compare
|
Updated! |
hzoo
reviewed
Feb 24, 2018
| { | ||
| "name": "webpack-v1-compatibility", | ||
| "devDependencies": { | ||
| "babel-loader": "^7.1.2", |
There was a problem hiding this comment.
Ah I was confused why it should be 7.1.1 but I guess there's an issue?
hzoo
reviewed
Feb 24, 2018
| // Later versions of babel-loader are incompatible with Webpack v1. | ||
| // https://github.com/babel/babel-loader/issues/505 | ||
| if (depsWebpack1 && dependencies['babel-loader']) { | ||
| console.log('Updating babel-loader to v7.1.1 as this project uses Webpack v1'); |
There was a problem hiding this comment.
Maybe we should say, please update webpack if you can 😄 https://webpack.js.org/guides/migrating/? don't have to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17.
When
babel-upgradeis run over a project that uses Webpack v1:babel-loader@7.1.1(from this suggestion)babel-core@^7.0.0-bridge.0This repo repros the bug from this issue. Running
babel-upgrade --installwith the diff from this PR fixes the Webpack error.