Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explainer [skip ci] #60

Merged
merged 2 commits into from
Apr 6, 2018
Merged

add explainer [skip ci] #60

merged 2 commits into from
Apr 6, 2018

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Apr 6, 2018

No description provided.

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe re-enforce that this will update official Babel packages (with a few exceptions, and we can list them) specifically?

Otherwise, LGTM.

readme.md Outdated
@@ -1,13 +1,20 @@
# babel-upgrade

## Usage
> A tool that tries to automatically update most dependencies, config files, and JavaScript files that require Babel packages directly to Babel v7 (and more in the future).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could make the link to http://new.babeljs.io/docs/en/next/v7-migration.html more prominent? that might be the best way to describe to most people what exactly it is attempting to update

readme.md Outdated
```bash
# npx lets you just run the command directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like # npx lets you run babel-upgrade without installing it locally might be a more straightforward wording?

@noahlemen
Copy link
Member

@FND do you have any input to add here? figured it would be worthwhile since you were the one to bring up these concerns in #20 (comment)!

@FND
Copy link

FND commented Apr 6, 2018

That all sounds much clearer now, so I'm all for it - thanks!

@hzoo hzoo merged commit 14de8ba into master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants