Fix plugins transform with array #85

isacjunior · 2018-09-02T00:55:37Z

Issue #84

nicolo-ribaudo

Instead of replacing the old plugin with an array of plugins and then, in a separate place, flatten the plugins list, I'd prefer if at

babel-upgrade/src/upgradeConfig.js

Lines 86 to 94 in 45d423f

    
           if (name === null) { 
        
             plugins.splice(i, 1); 
        
             i--; 
        
           } else { 
        
             if (isArray) plugin[0] = name; 
        
             else plugin = name; 
        
             plugins[i] = upgradeOptions(plugin); 
        
           }

we check if name is an array and handle it there.

nicolo-ribaudo · 2018-09-02T09:36:17Z

src/upgradeConfig.js

+function flattenPlugins(arr) {
+  let newArr = [];
+  arr && arr.forEach(a => {
+    const secondIsObject = typeof a[1] === 'object'


It can also be false or undefined.

fix plugins transform with array

2b1e2fd

nicolo-ribaudo reviewed Sep 2, 2018

View reviewed changes

danez added 2 commits March 23, 2019 01:48

Fix code

f94cb9a

Merge branch 'master' into plugin-iss84

0502e57

danez merged commit da41fce into babel:master Mar 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix plugins transform with array #85

Fix plugins transform with array #85

isacjunior commented Sep 2, 2018

nicolo-ribaudo left a comment

nicolo-ribaudo Sep 2, 2018

	if (name === null) {
	plugins.splice(i, 1);
	i--;
	} else {
	if (isArray) plugin[0] = name;
	else plugin = name;

	plugins[i] = upgradeOptions(plugin);
	}

Fix plugins transform with array #85

Fix plugins transform with array #85

Conversation

isacjunior commented Sep 2, 2018

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

nicolo-ribaudo Sep 2, 2018

Choose a reason for hiding this comment