Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[7.0] Move `legacy-decorators` into stage-1 preset 🎉 #5220
Closed
Milestone
Comments
hzoo
changed the title
This comment has been minimized.
This comment has been minimized.
|
I'll take this one |
This comment has been minimized.
This comment has been minimized.
|
#5225 |
This comment has been minimized.
This comment has been minimized.
|
Should this maybe be documented on the README for https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-decorators? I just tried using the non-legacy plugin and got the error, and only knew why by searching and finding this issue. |
This comment has been minimized.
This comment has been minimized.
|
@jharris4 Yes, I will update the documentation. @existentialism @hzoo This is a breaking change, right? |
hulkish
added a commit
to hulkish/babel
that referenced
this issue
May 2, 2017
* 7.0: (37 commits) resolved conflicts [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319) [7.0] Replacing current decorators with decorators-legacy (babel#5290) Add Node 7 to CI (babel#5165) [7.0] remove standalone babel package (babel#5293) .gitignore for test [skip ci] update yarn use lerna@2-beta.37 (babel#5254) [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263) [7.0] Remove quotes option (babel#5154) [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231) Remove babel-runtime from packages' dependencies (babel#5218) Bump `detect-indent`. (babel#5226) [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225) [7.0] Use lerna's --independent mode + changes (fixes babel#5221) [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189) [7.0] Added yarn.lock (babel#5175) [7.0] Remove old babel-runtime code (babel#5187) [7.0] Drop support for Node 5 (babel#5186) Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now the transform-decorators plugin in babel-preset-stage-2 just errors because it hasn't been implemented. (It's in progress).
In the meantime we should just remove it from stage 2 and then move the decorators legacy plugin by @loganfsmyth into stage-1. I want to say stage-1 since it hasn't been updated. When we implement the stage-2 spec one we can move it into stage-2.
git checkout 7.0and then make a branch off of that to PRmake buildafter a source code change or better just runmake watchin another terminal window to auto run babel while you are developing