Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Move `legacy-decorators` into stage-1 preset 馃帀 #5220

Closed
hzoo opened this issue Jan 26, 2017 · 4 comments
Closed

[7.0] Move `legacy-decorators` into stage-1 preset 馃帀 #5220

hzoo opened this issue Jan 26, 2017 · 4 comments

Comments

@hzoo
Copy link
Member

@hzoo hzoo commented Jan 26, 2017

Right now the transform-decorators plugin in babel-preset-stage-2 just errors because it hasn't been implemented. (It's in progress).

In the meantime we should just remove it from stage 2 and then move the decorators legacy plugin by @loganfsmyth into stage-1. I want to say stage-1 since it hasn't been updated. When we implement the stage-2 spec one we can move it into stage-2.

  • Comment below you are going to do this (for others to know)
  • Read CONTRIBUTING.md
  • Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
  • remember to run make build after a source code change or better just run make watch in another terminal window to auto run babel while you are developing

@hzoo hzoo added this to the Babel 7 milestone Jan 26, 2017
@hzoo hzoo changed the title [7.0] Move `legacy-decorators` into stage-1 preset [7.0] Move `legacy-decorators` into stage-1 preset 馃帀 Jan 26, 2017
@yavorsky

This comment has been minimized.

Copy link
Member

@yavorsky yavorsky commented Jan 26, 2017

I'll take this one 馃憣

yavorsky added a commit to yavorsky/babel that referenced this issue Jan 27, 2017
yavorsky added a commit to yavorsky/babel that referenced this issue Jan 27, 2017
yavorsky added a commit to yavorsky/babel that referenced this issue Jan 27, 2017
@babel-bot babel-bot added the Has PR label Jan 27, 2017
hzoo added a commit that referenced this issue Jan 27, 2017
@existentialism

This comment has been minimized.

Copy link
Member

@existentialism existentialism commented Jan 27, 2017

#5225 馃憤

@jharris4

This comment has been minimized.

Copy link

@jharris4 jharris4 commented Jan 29, 2017

Should this maybe be documented on the README for https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-decorators?

I just tried using the non-legacy plugin and got the error, and only knew why by searching and finding this issue.

@xtuc

This comment has been minimized.

Copy link
Member

@xtuc xtuc commented Jan 30, 2017

@jharris4 Yes, I will update the documentation.

@existentialism @hzoo This is a breaking change, right?

hulkish added a commit to hulkish/babel that referenced this issue May 2, 2017
* 7.0: (37 commits)
  resolved conflicts
  [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319)
  [7.0] Replacing current decorators with decorators-legacy (babel#5290)
  Add Node 7 to CI (babel#5165)
  [7.0] remove standalone babel package (babel#5293)
  .gitignore for test [skip ci]
  update yarn
  use lerna@2-beta.37 (babel#5254)
  [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263)
  [7.0] Remove quotes option (babel#5154)
  [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231)
  Remove babel-runtime from packages' dependencies (babel#5218)
  Bump `detect-indent`. (babel#5226)
  [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225)
  [7.0] Use lerna's --independent mode + changes (fixes babel#5221)
  [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189)
  [7.0] Added yarn.lock (babel#5175)
  [7.0] Remove old babel-runtime code (babel#5187)
  [7.0] Drop support for Node 5 (babel#5186)
  Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179)
  ...
@lock lock bot added the outdated label May 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.