Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 5 #5186

Merged
merged 2 commits into from Jan 21, 2017
Merged

Drop support for Node 5 #5186

merged 2 commits into from Jan 21, 2017

Conversation

@scottarnold
Copy link
Contributor

@scottarnold scottarnold commented Jan 21, 2017

This resolves #5185

@mention-bot
Copy link

@mention-bot mention-bot commented Jan 21, 2017

@scottarnold, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @hzoo and @sstern6 to be potential reviewers.

@hzoo
hzoo approved these changes Jan 21, 2017
Copy link
Member

@hzoo hzoo left a comment

Awesome! 👍

@hzoo
Copy link
Member

@hzoo hzoo commented Jan 21, 2017

Oops had to fix a merge conflict since I forgot to merge previously. sorry bout that

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 21, 2017

Current coverage is 89.61% (diff: 100%)

Merging #5186 into 7.0 will not change coverage

@@                7.0      #5186   diff @@
==========================================
  Files           200        200          
  Lines          9751       9751          
  Methods        1060       1060          
  Messages          0          0          
  Branches       2597       2597          
==========================================
  Hits           8738       8738          
  Misses         1013       1013          
  Partials          0          0          

Powered by Codecov. Last update 661102c...1d9dc05

@hzoo
Copy link
Member

@hzoo hzoo commented Jan 21, 2017

will merge after ci is done

@xtuc
xtuc approved these changes Jan 21, 2017
Copy link
Member

@xtuc xtuc left a comment

👍 Drop 🐢 🚀

@hzoo hzoo merged commit 20a5249 into babel:7.0 Jan 21, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 661102c...1d9dc05
Details
codecov/project 89.61% (+0.00%) compared to 661102c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo hzoo mentioned this pull request Jan 21, 2017
0 of 4 tasks complete
@scottarnold scottarnold deleted the scottarnold:patch-1 branch Jan 21, 2017
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 7.0: (37 commits)
  resolved conflicts
  [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319)
  [7.0] Replacing current decorators with decorators-legacy (babel#5290)
  Add Node 7 to CI (babel#5165)
  [7.0] remove standalone babel package (babel#5293)
  .gitignore for test [skip ci]
  update yarn
  use lerna@2-beta.37 (babel#5254)
  [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263)
  [7.0] Remove quotes option (babel#5154)
  [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231)
  Remove babel-runtime from packages' dependencies (babel#5218)
  Bump `detect-indent`. (babel#5226)
  [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225)
  [7.0] Use lerna's --independent mode + changes (fixes babel#5221)
  [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189)
  [7.0] Added yarn.lock (babel#5175)
  [7.0] Remove old babel-runtime code (babel#5187)
  [7.0] Drop support for Node 5 (babel#5186)
  Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179)
  ...
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.