New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 5 #5186

Merged
merged 2 commits into from Jan 21, 2017

Conversation

Projects
None yet
6 participants
@scottarnold
Contributor

scottarnold commented Jan 21, 2017

This resolves #5185

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 21, 2017

@scottarnold, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @hzoo and @sstern6 to be potential reviewers.

mention-bot commented Jan 21, 2017

@scottarnold, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @hzoo and @sstern6 to be potential reviewers.

@hzoo

hzoo approved these changes Jan 21, 2017

Awesome! 👍

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 21, 2017

Member

Oops had to fix a merge conflict since I forgot to merge previously. sorry bout that

Member

hzoo commented Jan 21, 2017

Oops had to fix a merge conflict since I forgot to merge previously. sorry bout that

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 21, 2017

Current coverage is 89.61% (diff: 100%)

Merging #5186 into 7.0 will not change coverage

@@                7.0      #5186   diff @@
==========================================
  Files           200        200          
  Lines          9751       9751          
  Methods        1060       1060          
  Messages          0          0          
  Branches       2597       2597          
==========================================
  Hits           8738       8738          
  Misses         1013       1013          
  Partials          0          0          

Powered by Codecov. Last update 661102c...1d9dc05

codecov-io commented Jan 21, 2017

Current coverage is 89.61% (diff: 100%)

Merging #5186 into 7.0 will not change coverage

@@                7.0      #5186   diff @@
==========================================
  Files           200        200          
  Lines          9751       9751          
  Methods        1060       1060          
  Messages          0          0          
  Branches       2597       2597          
==========================================
  Hits           8738       8738          
  Misses         1013       1013          
  Partials          0          0          

Powered by Codecov. Last update 661102c...1d9dc05

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 21, 2017

Member

will merge after ci is done

Member

hzoo commented Jan 21, 2017

will merge after ci is done

@xtuc

xtuc approved these changes Jan 21, 2017

👍 Drop 🐢 🚀

@hzoo hzoo merged commit 20a5249 into babel:7.0 Jan 21, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 661102c...1d9dc05
Details
codecov/project 89.61% (+0.00%) compared to 661102c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hzoo hzoo referenced this pull request Jan 21, 2017

Closed

[7.0] Drop Node 5 #5185

0 of 4 tasks complete

@scottarnold scottarnold deleted the scottarnold:patch-1 branch Jan 21, 2017

hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017

Merge branch '7.0'
* 7.0: (37 commits)
  resolved conflicts
  [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (#5318) (#5319)
  [7.0] Replacing current decorators with decorators-legacy (#5290)
  Add Node 7 to CI (#5165)
  [7.0] remove standalone babel package (#5293)
  .gitignore for test [skip ci]
  update yarn
  use lerna@2-beta.37 (#5254)
  [7.0] Run Babel's unittests in a custom sandbox (take 2). (#5263)
  [7.0] Remove quotes option (#5154)
  [7.0] List babylon plugins instead of * in babel-generator tests (#5231)
  Remove babel-runtime from packages' dependencies (#5218)
  Bump `detect-indent`. (#5226)
  [7.0] Add legacy-decorators to stage-1. Fixes #5220 (#5225)
  [7.0] Use lerna's --independent mode + changes (fixes #5221)
  [7.0] Bump `home-or-tmp` for `babel-register`. (#5189)
  [7.0] Added yarn.lock (#5175)
  [7.0] Remove old babel-runtime code (#5187)
  [7.0] Drop support for Node 5 (#5186)
  Remove path-is-absolute in favor of builtin path.isAbsolute (#5179)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment