New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel-runtime from packages' dependencies #5218

Merged
merged 4 commits into from Jan 27, 2017

Conversation

Projects
None yet
4 participants
@kaicataldo
Member

kaicataldo commented Jan 26, 2017

Q A
Patch: Bug Fix?
Major: Breaking Change? yes
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets Fixes #5118
License MIT
Doc PR
Dependency Changes

Worked with @hzoo to remove babel-runtime in preparation for dropping Node < 4 in Babel 7.0.

Updated packages/babel-runtime/scripts/build-dist.js to fix some ESLint warnings and remove dead code.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 26, 2017

Member

Not sure how we disable CircleCI only on 7.0 (or we just remove it from both) - currently just erroring on yarn since we need to fix that.

Member

hzoo commented Jan 26, 2017

Not sure how we disable CircleCI only on 7.0 (or we just remove it from both) - currently just erroring on yarn since we need to fix that.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 26, 2017

Current coverage is 89.61% (diff: 100%)

No coverage report found for 7.0 at e5aa501.

Powered by Codecov. Last update e5aa501...fa6dcfa

codecov-io commented Jan 26, 2017

Current coverage is 89.61% (diff: 100%)

No coverage report found for 7.0 at e5aa501.

Powered by Codecov. Last update e5aa501...fa6dcfa

@kaicataldo

This comment has been minimized.

Show comment
Hide comment
@kaicataldo

kaicataldo Jan 26, 2017

Member

Updated circle.yml to use Yarn!

Member

kaicataldo commented Jan 26, 2017

Updated circle.yml to use Yarn!

@@ -18,7 +18,6 @@
"babel-preset-es2015": "^6.13.2",
"babel-preset-stage-0": "^6.0.0",
"babel-register": "^6.14.0",
"babel-runtime": "^6.0.0",

This comment has been minimized.

@hzoo

hzoo Jan 26, 2017

Member

We can also remove "babel-plugin-transform-runtime" from the devDeps now

Also I believe the ignore key in lerna.json

  "bootstrapConfig": {
    "ignore": "babel-runtime"
  },

and the extra npm install for babel-runtime

babel/Makefile

Line 75 in 446b4a7

npm install; \

Ref #3509

@hzoo

hzoo Jan 26, 2017

Member

We can also remove "babel-plugin-transform-runtime" from the devDeps now

Also I believe the ignore key in lerna.json

  "bootstrapConfig": {
    "ignore": "babel-runtime"
  },

and the extra npm install for babel-runtime

babel/Makefile

Line 75 in 446b4a7

npm install; \

Ref #3509

@hzoo hzoo requested review from loganfsmyth and danez Jan 26, 2017

@hzoo hzoo added this to the Babel 7 milestone Jan 26, 2017

@hzoo

hzoo approved these changes Jan 26, 2017

@existentialism

💯

@hzoo hzoo merged commit e09ea22 into 7.0 Jan 27, 2017

0 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@hzoo hzoo deleted the remove-runtime branch Jan 28, 2017

hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017

Merge branch '7.0'
* 7.0: (37 commits)
  resolved conflicts
  [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (#5318) (#5319)
  [7.0] Replacing current decorators with decorators-legacy (#5290)
  Add Node 7 to CI (#5165)
  [7.0] remove standalone babel package (#5293)
  .gitignore for test [skip ci]
  update yarn
  use lerna@2-beta.37 (#5254)
  [7.0] Run Babel's unittests in a custom sandbox (take 2). (#5263)
  [7.0] Remove quotes option (#5154)
  [7.0] List babylon plugins instead of * in babel-generator tests (#5231)
  Remove babel-runtime from packages' dependencies (#5218)
  Bump `detect-indent`. (#5226)
  [7.0] Add legacy-decorators to stage-1. Fixes #5220 (#5225)
  [7.0] Use lerna's --independent mode + changes (fixes #5221)
  [7.0] Bump `home-or-tmp` for `babel-register`. (#5189)
  [7.0] Added yarn.lock (#5175)
  [7.0] Remove old babel-runtime code (#5187)
  [7.0] Drop support for Node 5 (#5186)
  Remove path-is-absolute in favor of builtin path.isAbsolute (#5179)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment