Remove babel-runtime from packages' dependencies #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
added
PR: Breaking Change 💥
|
Not sure how we disable CircleCI only on 7.0 (or we just remove it from both) - currently just erroring on yarn since we need to fix that. |
Current coverage is 89.61% (diff: 100%)
|
kaicataldo
force-pushed
the
remove-runtime
branch
from
f257c7c
to
72347ae
Compare
|
Updated circle.yml to use Yarn! |
kaicataldo
force-pushed
the
remove-runtime
branch
from
72347ae
to
3099d91
Compare
hzoo
reviewed
Jan 26, 2017
| @@ -18,7 +18,6 @@ | |||
| "babel-preset-es2015": "^6.13.2", | |||
| "babel-preset-stage-0": "^6.0.0", | |||
| "babel-register": "^6.14.0", | |||
| "babel-runtime": "^6.0.0", | |||
There was a problem hiding this comment.
We can also remove "babel-plugin-transform-runtime" from the devDeps now
Also I believe the ignore key in lerna.json
"bootstrapConfig": {
"ignore": "babel-runtime"
},and the extra npm install for babel-runtime
Line 75 in 446b4a7
Ref #3509
hzoo
approved these changes
Jan 26, 2017
5 tasks
hulkish
added a commit
to hulkish/babel
that referenced
this pull request
May 2, 2017
* 7.0: (37 commits) resolved conflicts [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319) [7.0] Replacing current decorators with decorators-legacy (babel#5290) Add Node 7 to CI (babel#5165) [7.0] remove standalone babel package (babel#5293) .gitignore for test [skip ci] update yarn use lerna@2-beta.37 (babel#5254) [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263) [7.0] Remove quotes option (babel#5154) [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231) Remove babel-runtime from packages' dependencies (babel#5218) Bump `detect-indent`. (babel#5226) [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225) [7.0] Use lerna's --independent mode + changes (fixes babel#5221) [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189) [7.0] Added yarn.lock (babel#5175) [7.0] Remove old babel-runtime code (babel#5187) [7.0] Drop support for Node 5 (babel#5186) Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179) ...
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked with @hzoo to remove babel-runtime in preparation for dropping Node < 4 in Babel 7.0.
Updated
packages/babel-runtime/scripts/build-dist.jsto fix some ESLint warnings and remove dead code.