Add stricter Optional Chain node validation #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
approved these changes
Mar 12, 2020
JLHwung
reviewed
Mar 12, 2020
Optional chains cannot start with `optional: false`. Somewhere in the `object`/`callee` tree, there must be an optional with `optional: true`.
jridgewell
force-pushed
the
stricter-optional-chain
branch
from
dd9fdc4
to
db8922b
Compare
nicolo-ribaudo
approved these changes
Mar 17, 2020
nicolo-ribaudo
added
the
PR: Internal 🏠
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 11, 2020
This was referenced Apr 17, 2020
This was referenced Apr 24, 2020
This was referenced May 2, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional chains cannot start with
optional: false. Somewhere in theobject/calleetree, there must be an optional withoptional: true.