Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] Add asserts: false to TSTypePredicate node #12167

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Oct 13, 2020

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When babel-parser parses asserts function, it attach asserts: true to TSTypePredicate.

However, when parsing the normal type predication function, it doesn't attach asserts: false to TSTypePredicate.

typescript-eslint/typescript-estree adds asserts: true/false to both. This PR aligns AST for Babel and typescript-estree. (ref: https://github.com/typescript-eslint/typescript-eslint/blob/c41dbe56e0514846e4d21fc5fcd8847da50e92c6/packages/typescript-estree/tests/ast-alignment/utils.ts#L259-L268)

Please close this PR if the current behavior is intentional:smile:

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29855/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5f78410:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Oct 13, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit a5bed04 into babel:main Oct 13, 2020
@nicolo-ribaudo
Copy link
Member

Thanks!

@sosukesuzuki sosukesuzuki deleted the align-asserts-property branch October 13, 2020 23:57
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants