[ts] Add asserts: false
to TSTypePredicate
node
#12167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When babel-parser parses asserts function, it attach
asserts: true
toTSTypePredicate
.However, when parsing the normal type predication function, it doesn't attach
asserts: false
toTSTypePredicate
.typescript-eslint/typescript-estree adds
asserts: true/false
to both. This PR aligns AST for Babel and typescript-estree. (ref: https://github.com/typescript-eslint/typescript-eslint/blob/c41dbe56e0514846e4d21fc5fcd8847da50e92c6/packages/typescript-estree/tests/ast-alignment/utils.ts#L259-L268)Please close this PR if the current behavior is intentional:smile: