Report single error for invalid num seps in unicode escapes #14338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Polish 💅
nicolo-ribaudo
commented
Mar 8, 2022
| "errors": [ | ||
| "SyntaxError: Numeric separators are not allowed inside unicode escape sequences or hex escape sequences. (1:4)", | ||
| "SyntaxError: Numeric separators are not allowed inside unicode escape sequences or hex escape sequences. (1:5)", | ||
| "SyntaxError: Invalid Unicode escape. (1:0)" |
There was a problem hiding this comment.
The reason for this thirs error is that \uXXXX expects 4 characters after u, so it parses 00__ which is 0 and is an invalid character in variable names.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51433/ |
existentialism
approved these changes
Mar 8, 2022
JLHwung
approved these changes
Mar 8, 2022
1 task
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, for
\u{_abcd}we would throw both that a number cannot have a leading_, and that they are disallowed in this position.