Support indices.groups when compiling named groups in regexps
#15092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53301/ |
nicolo-ribaudo
added
the
PR: Bug Fix 
|
I'm marking this as a bugfix because it just adds a missing piece of a proposal we already implemented (duplicate named groups), and it only works in browsers that already support |
nicolo-ribaudo
reviewed
Oct 29, 2022
|
For the failing tests: Node.js 14 and older don't support
|
If a RegExp has the /d flag (hasIndices), match objects should have an extra property .indices with an array of the character indices that each subgroup matched. The indices array itself has a property .groups giving the matched character indices (or undefined) for each named capturing group. This doesn't do anything to enable support for the /d flag, the hasIndices property, or the returned indices object, if the environment does not support it, but it will populate .indices.groups in _wrapRegExp if .indices is present, so that the transform-named-capturing-groups-regex and proposal-duplicate-named-capturing-groups-regex plugins can take advantage of that support if it exists.
nicolo-ribaudo
changed the title
indices.groups when compiling named groups in regexps
nicolo-ribaudo
approved these changes
Oct 31, 2022
JLHwung
approved these changes
Oct 31, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a RegExp has the
/dflag (hasIndices), match objects should have an extra property.indiceswith an array of the character indices that each subgroup matched. The indices array itself has a property.groupsgiving the matched character indices (or undefined) for each named capturing group.This doesn't do anything to enable support for the
/dflag, the.hasIndicesproperty, or the returned indices object, if the environment does not support it, but it will populate.indices.groupsin_wrapRegExpif.indicesis present, so that the transform-named-capturing-groups-regex and proposal-duplicate-named-capturing-groups-regex plugins can take advantage of that support if it exists.