Remove Babel 7 e2e ESM tests #15837
Merged
Remove Babel 7 e2e ESM tests #15837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55027/ |
liuxingbaoyu
approved these changes
Aug 3, 2023
JLHwung
approved these changes
Aug 3, 2023
lucasavila00
pushed a commit
to lucasavila00/babel
that referenced
this pull request
Aug 3, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2With #15836 and #15832, we now run the same ESM e2e tests for Babel 7 and Babel 8. Given that we are only going to publish Babel 8 as ESM, there is no value in also testing Babel 7 and we can skip running some CI jobs (less overload for CI, less CO2!)
Additionally, this means that we will only have to care about published code compatibility of Babel 7 + CJS and Babel 8 + ESM. #15792 is currently failing in our e2e tests due due to Babel 7 + ESM (which does not fail in local development due to our dual setup, and just in published code), and fixing it is a bit wasteful given that we don't need it to work in the real world 😛