Merge master into 7.0 #5368
Merged
Merge master into 7.0 #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first for-await was correctly printed all subsequent for-await statements where printed as for-of as the variable op was changed inside the buildForXStatement
* Pass `dirname` as extra metadata to preset constructor. Sometimes a preset would like to know where it should resolve relative paths from (e.g. https://github.com/tleunen/babel-plugin-module-resolver) and this extra information makes that possible. * Test for `dirname` passed into preset constructor This adds a check for `dirname`’s existence and correctness to the `resolve-addons-relative-to-file` test, and serves as a minimal example of a path-aware preset.
`NODE_ENV=test` is exported by default. Therefore, targets that set `NODE_ENV` to `test` are cleaned up.
Codecov Report
@@ Coverage Diff @@
## 7.0 #5368 +/- ##
==========================================
- Coverage 90.38% 85.24% -5.14%
==========================================
Files 204 204
Lines 9891 9570 -321
Branches 2695 2694 -1
==========================================
- Hits 8940 8158 -782
+ Misses 951 920 -31
- Partials 0 492 +492
Continue to review full report at Codecov.
|
xtuc
approved these changes
Feb 25, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge conflicts
UU packages/babel-core/src/transformation/file/options/option-manager.js
UU packages/babel-core/test/fixtures/resolution/resolve-addons-relative-to-file/node_modules/addons/preset.js
UU packages/babel-generator/src/generators/statements.js (nothing)
if approved, just git push from cli