Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused alias in babel-runtime #5516

Merged
merged 2 commits into from
Mar 23, 2017
Merged

removed unused alias in babel-runtime #5516

merged 2 commits into from
Mar 23, 2017

Conversation

JulianJason
Copy link
Contributor

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Pass
Fixed Tickets #5472
License MIT
Doc PR
Dependency Changes

Removed unused alias from babel runtime. Used to be built for compability but it is safe to remove.

@mention-bot
Copy link

@JulianJason, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Kovensky, @loganfsmyth and @zertosh to be potential reviewers.

@JulianJason
Copy link
Contributor Author

JulianJason commented Mar 21, 2017

Hey this is my first PR in open source, please be harsh and criticize me so I can learn. Thank you.

@codecov
Copy link

codecov bot commented Mar 21, 2017

Codecov Report

Merging #5516 into 7.0 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              7.0    #5516      +/-   ##
==========================================
- Coverage   85.34%   85.33%   -0.02%     
==========================================
  Files         201      201              
  Lines        9485     9485              
  Branches     2689     2689              
==========================================
- Hits         8095     8094       -1     
- Misses        897      898       +1     
  Partials      493      493
Impacted Files Coverage Δ
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c905c...2831428. Read the comment docs.

@hzoo hzoo added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Mar 22, 2017
@hzoo hzoo added this to the Babel 7 milestone Mar 22, 2017
@hzoo hzoo merged commit 640515b into babel:7.0 Mar 23, 2017
@hzoo
Copy link
Member

hzoo commented Mar 23, 2017

Awesome 👍

@hzoo
Copy link
Member

hzoo commented Mar 23, 2017

Only thing is that you should add Fixes #number so that the issue closes when merged (assuming it does actually fix it and you don't want to just reference it)

@JulianJason JulianJason deleted the remove-unused-runtime-alias branch March 23, 2017 03:55
@JulianJason
Copy link
Contributor Author

Thank you so much @hzoo

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants