Remove noop #5970
Merged
Remove noop #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s ugly, but it gets the job done. And it unblocks my babel-type changes.
|
@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @danharper to be potential reviewers. |
|
We were thinking of deprecating this plugin anyway since we have issues with adding comments in the right places when transpiling say classes. And t.noop isn't a regular node so probably don't want anyone relying on it. Dono how this would be codemoded though |
hzoo
added
the
PR: Breaking Change 💥
existentialism
approved these changes
Jul 20, 2017
|
I'd be fine with this plugin if it only stripped annotations. You shouldn't be lookin at a build product for type info. |
|
We already have a strip-types plugin which is what babel-preset-flow uses so that's why we were going to deprecate |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s ugly, but it gets the job done. And it unblocks my babel-type changes.
There are probably breaking changes. The flow ast is completely unknown, so I'm not really concerned. It at least removes them.