Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noop #5970

Merged
merged 1 commit into from Jul 20, 2017
Merged

Remove noop #5970

merged 1 commit into from Jul 20, 2017

Conversation

@jridgewell
Copy link
Member

jridgewell commented Jul 19, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? Probably
Minor: New Feature? No
Deprecations? Noop
Spec Compliancy? No
Tests Added/Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes

It’s ugly, but it gets the job done. And it unblocks my babel-type changes.

There are probably breaking changes. The flow ast is completely unknown, so I'm not really concerned. It at least removes them.

It’s ugly, but it gets the job done. And it unblocks my babel-type
changes.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jul 19, 2017

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @danharper to be potential reviewers.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Jul 20, 2017

We were thinking of deprecating this plugin anyway since we have issues with adding comments in the right places when transpiling say classes. And t.noop isn't a regular node so probably don't want anyone relying on it. Dono how this would be codemoded though

@hzoo hzoo merged commit 7854441 into babel:7.0 Jul 20, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 85.76% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell

This comment has been minimized.

Copy link
Member Author

jridgewell commented Jul 20, 2017

I'd be fine with this plugin if it only stripped annotations. You shouldn't be lookin at a build product for type info.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Jul 20, 2017

We already have a strip-types plugin which is what babel-preset-flow uses so that's why we were going to deprecate

@jridgewell jridgewell deleted the jridgewell:remove-noop branch Jul 20, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.